Bug 460422 - kernel: ext2 does not force ro-mode when revision level is too high [rhel-4.8]
Summary: kernel: ext2 does not force ro-mode when revision level is too high [rhel-4.8]
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel
Version: 4.8
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Martin Jenner
Depends On: 460421
Blocks: 461304
TreeView+ depends on / blocked
Reported: 2008-08-28 07:41 UTC by Eugene Teo (Security Response)
Modified: 2010-04-01 19:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-04-01 19:57:36 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Eugene Teo (Security Response) 2008-08-28 07:41:12 UTC
+++ This bug was initially created as a clone of Bug #460421 +++

Description of problem:
The ext2 filesystem does not force read-only mode when the revision level is too high. That is, when le32_to_cpu(es->s_rev_level) > EXT3_MAX_SUPP_REV.

Comment 2 Eugene Teo (Security Response) 2008-08-28 07:43:28 UTC
 738 static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 739 {
1066     ext2_setup_super (sb, es, sb->s_flags & MS_RDONLY);
1067     return 0;

 576 static int ext2_setup_super (struct super_block * sb,
 577                   struct ext2_super_block * es,
 578                   int read_only)
 579 {
 580     int res = 0;
 581     struct ext2_sb_info *sbi = EXT2_SB(sb);
 583     if (le32_to_cpu(es->s_rev_level) > EXT2_MAX_SUPP_REV) {
 584         printk ("EXT2-fs warning: revision level too high, "
 585             "forcing read-only mode\n");
 586         res = MS_RDONLY;
 587     }
 618     return res;
 619 }

It doesn't look like this piece of code is tested at all. The status returned from ext2_setup_super is not checked, so what it did was to print a warning message. I believe this should be done in the early part of ext2_fill_super().

Comment 5 RHEL Program Management 2008-09-03 13:09:55 UTC
Updating PM score.

Comment 7 RHEL Program Management 2009-03-12 18:57:34 UTC
Since RHEL 4.8 External Beta has begun, and this bugzilla remains 
unresolved, it has been rejected as it is not proposed as exception or 

Comment 8 Eric Sandeen 2010-04-01 19:57:36 UTC
I don't think this is a critical fix for RHEL at this point.

Note You need to log in before you can comment on or make changes to this bug.