Bug 460694 - urllib2 fd leak, with r.recv = r.read
Summary: urllib2 fd leak, with r.recv = r.read
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: python
Version: 5.2
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: James Antill
QA Contact: Alexander Todorov
URL:
Whiteboard:
: 468282 (view as bug list)
Depends On: 471224
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-29 18:53 UTC by James Antill
Modified: 2013-04-12 16:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 20:34:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:0067 0 normal SHIPPED_LIVE python bug fix update 2009-01-20 16:04:06 UTC

Description James Antill 2008-08-29 18:53:40 UTC
Description of problem:

 This is a local tracker for the upstream bug:

http://bugs.python.org/issue3066

...I've made a patch for it, and we could test that.

 It was found by using yum/reposync, and being unlucky and not getting a GC cellect.

 This varient doesn't really affect RHEL/RHN as we are really hit by 460692, due to using SSL. However non-RHN repos. like EPEL, etc. will hit this varient.

 I'm going to propose it for 5.3, as python is an approved component, and we can at least test the fix to see what happens.

Comment 1 James Antill 2008-08-29 18:54:28 UTC
 That's bug 460692

Comment 2 RHEL Program Management 2008-08-29 19:12:29 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Charles Duffy 2008-08-29 20:30:20 UTC
This bug is of interest to Dell MessageOne (related to internal ticket PUP-283); adding appropriate CCs.

Comment 8 Petr Šplíchal 2008-10-21 12:59:15 UTC
Well, the reproducer works ok with the new version of python package. But the issue is still present when tested with yumdownloader or reposync. There are as many file descriptors opened as there are packages downloaded (for example 333 packages, 337 opened file descriptors). When the number of downloaded packages exceeds current ulimit settings, it fails with:

IOError: [Errno 24] Too many open files

This can be reproduced with any repository which allows keep-alive connections. With keep-alive disabled the issue is not present. I don't know how many repositories allow keep-alive connections and are therefore affected with this.

Comment 10 Charles Duffy 2008-10-21 16:44:38 UTC
Petr,

When testing against yumdownloader or reposync, was this from a HTTP or HTTPS source? If the latter (as James noted), <A HREF="https://bugzilla.redhat.com/show_bug.cgi?id=460692">bug 460692</A> is relevant.

Comment 11 Petr Šplíchal 2008-10-22 07:23:33 UTC
I've tested with my local HTTP repository:

    [testrepo]
    name=Python urllib2 fd leak testing repository
    baseurl=http://localhost/testrepo
    enabled=1
    gpgcheck=0

So this case should not be affected with bug 460692.

Comment 12 James Antill 2008-10-23 21:22:24 UTC
*** Bug 468282 has been marked as a duplicate of this bug. ***

Comment 13 Petr Šplíchal 2008-10-30 11:10:50 UTC
Moving the bug back to ASSIGNED as the yumdownloader/reposync issue is not fixed in current version (see comment #8), James is already looking into it...

Comment 22 errata-xmlrpc 2009-01-20 20:34:39 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0067.html


Note You need to log in before you can comment on or make changes to this bug.