Red Hat Bugzilla – Bug 460886
Review Request: libnetdude - a libpcap trace file manipulation library
Last modified: 2008-12-22 09:17:34 EST
Spec URL: http://www.icir.org/christian/fedora/libnetdude.spec SRPM URL: http://www.icir.org/christian/fedora/libnetdude-0.11-1.src.rpm Description: libnetdude is the packet manipulating backend of Netdude, the network dump data editing framework. It fills the gap between the low-level libpcap API and the high-level requirements for packet manipulation applications. libnetdude provides data types and an API for the most common requirements when dealing with libpcap trace files: trace files, packets, network protocols, packet iterators, packet filters. libnetdude supports manipulation of arbitrarily large trace files, and is extendable through a plugin facility. Please note: I need a sponsor.
rpmlint says... [rpm@laptop024 SRPMS]$ rpmlint libnetdude-0.11-1.src.rpm libnetdude.src:17: W: hardcoded-packager-tag Christian libnetdude.src:19: W: hardcoded-prefix-tag %{prefix} libnetdude.src:47: W: configure-without-libdir-spec libnetdude.src: W: no-version-in-last-changelog 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Some quick comments on your spec: - use macros http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros - Don't use tag 'Packager' - The Tag 'Release' should incl. %{?dist} and bumped with every new version of your spec file. - %changelog, add version and release according the sample in the Package HowTo More details can be found http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo
Fabian, I can sponsor Christian once you complete the full review. If you like I can just do the review as well. I'll be doing the review this blocks, just want to avoid treading on toes. :)
Hi guys, thanks for the sponsor offer and the RPM suggestions. I'll address them asap and post an update when complete.
Jon, I can do a full review later but it would be good if a packager with some experience check my review.
Fabian, I suggest to go ahead, assign the bug to yourself and do the review. Either Jon or myself will check after that.
(In reply to comment #5) > Fabian, I suggest to go ahead, assign the bug to yourself and do the review. > Either Jon or myself will check after that. +1
I'm willing to do this review. Post updated versions addressing Fabian's comments in #1, and I'll assign to myself and complete.
As discussed with christian, I'm offering to do the review as I already did the same work and we'd be able to comaintain the package in the future: SPEC: http://home.bawue.de/~ixs/libnetdude/libnetdude.spec SRPM: http://home.bawue.de/~ixs/libnetdude/libnetdude-0.11-1.fc9.src.rpm libnetdude allows to implement trace file manipulations at a much higher level of abstraction than code written directly on top of the pcap library. It also provides a command-line interface that directly lets you script all packet- mangling capabilities provided by the set of plugins you have installed. [athienem@localhost libnetdude]$ rpmlint /var/lib/mock/fedora-rawhide-*/result/*.rpm 8 packages and 0 specfiles checked; 0 errors, 0 warnings. [athienem@localhost libnetdude]$
Will you be sponsoring him then?
Currently who is the submitter and who is the reviewer?
Christian is the submitter, and Andreas is the reviewer, AFAIK. Andreas can now sponsor.
Jon got that right. As discussed with Christian, he's happy for me to do the review, so I'll just set the flags then, and assign it. Everybody happy with that?
A note about the libnetdude.spec from me, that one is a package I created for some project at Red Hat and posted here for reference.
Since the submitter hasn't responded to the libpcapnav review after many weeks and multiple pings, it has been closed and thus this must be closed as well.
*** This bug has been marked as a duplicate of bug 477545 ***