Bug 461241 (utilities-lvm) - Icon reference in .desktop file contains full path to icon file and extension (.png)
Summary: Icon reference in .desktop file contains full path to icon file and extension...
Alias: utilities-lvm
Product: Fedora
Classification: Fedora
Component: system-config-lvm
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marek Grac
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-09-05 09:37 UTC by Luya Tshimbalanga
Modified: 2009-10-30 12:22 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Last Closed: 2009-10-30 09:23:52 UTC
Type: ---

Attachments (Terms of Use)

Description Luya Tshimbalanga 2008-09-05 09:37:31 UTC
Description of problem:
Similar to other system-config*, icon reference in .desktop file contains file extension (.png) which prevents
effectively theming it, e.g. if the used icon theme is based solely on SVGs

Version-Release number of selected component (if applicable):

Additional info:
Just dropping the extension is fine (i.e. to Icon=system-config-lvm), but
would be even better if the icon name could be changed to something more
general and follow the Icon Naming Guidelines [1]. I'd suggest

Also, as the icon is used in the application itself, it would be nice to look
it up the correct way [2]. GTK has already prepared look-up functions for that,
so the implementation should not be hard. Patch attached to bug #454402 might
be helpful.



Comment 1 Martin Sourada 2008-09-05 09:47:17 UTC
The problem is slightly worse than just extension - in this case the .destkop file contains full path to icon (or contained the last time I checked) which prevents theming completely. Correct way is to install the icon into hicolor icon theme and use only icon name (without extension) in the .desktop file.

Comment 2 Marek Grac 2009-10-30 09:23:52 UTC
System-config-lvm is entering maintainance-only mode and whole package will be deprecated. We do not plan active development, only major bugs will be fixed.

Comment 3 Luya Tshimbalanga 2009-10-30 10:38:33 UTC
Which package will supersede system-config-lwm?

Comment 4 Marek Grac 2009-10-30 12:22:37 UTC
Application that is part of GNOME (if I'm right it is gnome-disk-utility), it does not support lvm yet but that will be fixed soon.

Note You need to log in before you can comment on or make changes to this bug.