Bug 461303 - Review Request: perl-Data-Section - Read multiple hunks of data out of your DATA section
Summary: Review Request: perl-Data-Section - Read multiple hunks of data out of your D...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 461307
TreeView+ depends on / blocked
Reported: 2008-09-05 18:04 UTC by Daniel Berrangé
Modified: 2012-04-02 18:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-09-10 10:33:20 UTC
Type: ---
tibbs: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
Patch to get test suite to work with Test::More < 0.88 (373 bytes, patch)
2012-03-06 12:11 UTC, Paul Howarth
no flags Details | Diff

Description Daniel Berrangé 2008-09-05 18:04:39 UTC
Spec URL: http://berrange.fedorapeople.org/review/perl-Data-Section/perl-Data-Section.spec
SRPM URL: http://berrange.fedorapeople.org/review/perl-Data-Section/perl-Data-Section-0.005-1.fc9.src.rpm
Data::Section provides an easy way to access multiple named chunks of line-
oriented data in your module's DATA section. It was written to allow
modules to store their own templates, but probably has other uses.

This new package is a requirement to upgrade perl-Module-CPANTS-Analyse to latest upstream release

Comment 1 Jason Tibbitts 2008-09-06 00:01:27 UTC
Fails to build for me (in rawhide); the tests fail due to a lack of Test::More.  Even by-the-book cpanspec-generated packages may be missing a few things.  I added a build dependency on perl(Test::More) and things build OK, so I'll just assume that it's there and go on.

Otherwise everything looks fine.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (after adding perl(Test::More)).
* %clean is present.
* package builds in mock (rawhide, x86_64) (after fixing build deps).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Data::Section) = 0.005
   perl-Data-Section = 0.005-1.fc10
   perl(Sub::Exporter) >= 0.979

* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=19,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.07 cusr  0.01 
    csys =  0.11 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, just fix that build dep so that you can actually build the package.

Comment 2 Daniel Berrangé 2008-09-06 09:42:31 UTC
Thanks for the review - I always forget the Test::More BR as its always present on my installs. Will do a proper mock build next time to validate it.

Comment 3 Kevin Fenzi 2008-09-08 15:24:56 UTC
Can you add a cvs request here? 
See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Comment 4 Daniel Berrangé 2008-09-08 15:30:20 UTC
New Package CVS Request
Package Name: perl-Data-Section
Short Description: Read multiple hunks of data out of your DATA section
Owners: berrange
Branches: F-9

Comment 5 Ralf Corsepius 2008-09-10 01:47:23 UTC
Daniel, one piece of recommendation:

Would you please consider to add "InitialCC: perl-sig" to your perl packages? Many perl packagers apply this, because this causes BZ's and commits to be CC:'ed to the fedora-perl-devel list, thus automatically notifies them about issues with perl packages - Thanks in advance.

Comment 6 Kevin Fenzi 2008-09-10 02:20:50 UTC
cvs done.

Comment 7 Daniel Berrangé 2008-09-10 10:33:20 UTC
Ralf, looks like PkgDB is already setup, so too late to add InitialCC - someone will have to request it in pkgdb directly. I'll add it to any future perl RPMs I add

Build now in rawhide:

$ koji latest-pkg dist-f10 perl-Data-Section
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
perl-Data-Section-0.005-2.fc10            dist-f10              berrange

Comment 8 Daniel Berrangé 2010-06-29 11:30:42 UTC

Package Change Request
Package Name: perl-Data-Section
New Branches: EL-6
Owners: berrange

Comment 9 Kevin Fenzi 2010-06-30 00:58:38 UTC
CVS done (by process-cvs-requests.py).

Comment 10 Paul Howarth 2012-03-05 15:12:24 UTC
Hi Daniel,

can we have an EL-5 branch for this package please? I have already requested the necessary update of Sub::Exporter (Bug #799993) and have a patch to get the test suite to work with Test::More < 0.88 as found in EL-5. I (pghmcfc) would be happy to maintain this branch if you're not interested.

Comment 11 Daniel Berrangé 2012-03-06 11:44:32 UTC
Package Change Request
Package Name: perl-Data-Section
New Branches: EL-5
Owners: berrange

Comment 12 Paul Howarth 2012-03-06 12:11:37 UTC
Created attachment 567930 [details]
Patch to get test suite to work with Test::More < 0.88

Comment 13 Gwyn Ciesla 2012-03-06 13:01:38 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2012-03-18 11:46:43 UTC
perl-Data-Section-0.101621-2.el5 has been submitted as an update for Fedora EPEL 5.

Comment 15 Fedora Update System 2012-04-02 18:27:34 UTC
perl-Data-Section-0.101621-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Note You need to log in before you can comment on or make changes to this bug.