Fedora Account System
Red Hat Associate
Red Hat Customer
It seems that with Rawhide rpm, not found patches do not terminate the build, they just print out an error. With the "Patch0: not applied with %patch and Patch: not applied with %patch0" change in the new rpm, this will cause quite a few regressions and possibly security issues unless people happen to read their build logs carefully - essentially some patches just do not get applied. One example here: http://kojipkgs.fedoraproject.org/packages/mboxgrep/0.7.9/6.fc10/data/logs/x86_64/build.log [...] Executing command: ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/mboxgrep.spec'] /etc/profile: line 38: /bin/hostname: No such file or directory error: %patch without corresponding "Patch:" tag Building target platforms: x86_64 Building for target x86_64 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.Kbstjz [...] An error is printed, but the build continues without the patch applied. The build should IMO be terminated instead. I don't have a Rawhide box to test with, but can reproduce locally in mock on a F-9 system. I hacked my mock to not use --nodeps with rpmbuild -bb just to try it out, but it had no effect on this issue. There are about 60 packages in Rawhide that are potentially affected, will post to fedora-devel about it soon.
Fixed in upstream and rawhide. Thanks for noticing.