SRPM URL: http://fedora.biggerontheinside.net/review/perl-Tie-ToObject-0.03-1.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Tie-ToObject.spec Description: While the perldoc/tie manpage allows tying to an arbitrary object, the class in question must support this in it's implementation of 'TIEHASH', 'TIEARRAY' or whatever. This class provides a very tie constructor that simply returns the object it was given as it's first argument. This way side effects of calling '$object->TIEHASH' are avoided.
http://koji.fedoraproject.org/koji/taskinfo?taskID=811495 =====> perl-Tie-ToObject-0.03-1.fc9.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Tie-ToObject-0.03-1.fc9.noarch.rpm perl(Tie::ToObject) = 0.03 perl-Tie-ToObject = 0.03-1.fc9 ====> requires for perl-Tie-ToObject-0.03-1.fc9.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Scalar::Util) perl(strict) perl(vars) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=811495 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b4f434992c286d531f26893c78541456 Tie-ToObject-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=10, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.05 cusr 0.01 csys = 0.07 CPU) + Package perl-Tie-ToObject-0.03-1.fc10 => Provides: perl(Tie::ToObject) = 0.03 Requires: perl(Carp) perl(Scalar::Util) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-Tie-ToObject Short Description: Tie to an existing object Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done.
Imported and building. Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-Tie-ToObject New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).
Package Change Request ====================== Package Name: perl-Tie-ToObject New Branches: epel7 Owners: lkundrak The Fedora maintainer (iarnell) is not willing to maintain EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo