Bug 461428 - Review Request: orsa - Orbit Reconstruction, Simulation and Analysis
Summary: Review Request: orsa - Orbit Reconstruction, Simulation and Analysis
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-07 20:56 UTC by Milos Jakubicek
Modified: 2008-10-16 02:07 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-09-29 08:42:21 UTC
Type: ---
Embargoed:
lkundrak: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Milos Jakubicek 2008-09-07 20:56:18 UTC
Spec URL: http://mjakubicek.fedorapeople.org/orsa/orsa.spec
SRPM URL: http://mjakubicek.fedorapeople.org/orsa/orsa-0.7.0-1.fc9.src.rpm
Description: ORSA is an interactive tool for scientific grade Celestial Mechanics
computations. Asteroids, comets, artificial satellites, Solar and extra-Solar
planetary systems can be accurately reproduced, simulated, and analyzed. 

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=812247

Comment 1 Lubomir Rintel 2008-09-09 20:58:38 UTC
You don't seem to honour %{optflags} every where, see the following snippt from build.log:

make[4]: Entering directory `/builddir/build/BUILD/orsa-0.7.0/src/liborsa'
source='orsa_secure_math.cc' object='orsa_secure_math.lo' libtool=yes \
	depfile='.deps/orsa_secure_math.Plo' tmpdepfile='.deps/orsa_secure_math.TPlo' \
	depmode=gcc3 /bin/sh ../../depcomp \
	/bin/sh ../../libtool --tag=CXX --mode=compile mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./..  -DQT_THREAD_SUPPORT  -D_REENTRANT  -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include     -c -o orsa_secure_math.lo `test -f 'orsa_secure_math.cc' || echo './'`orsa_secure_math.cc
source='orsa_body.cc' object='orsa_body.lo' libtool=yes \
	depfile='.deps/orsa_body.Plo' tmpdepfile='.deps/orsa_body.TPlo' \
	depmode=gcc3 /bin/sh ../../depcomp \
	/bin/sh ../../libtool --tag=CXX --mode=compile mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./..  -DQT_THREAD_SUPPORT  -D_REENTRANT  -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include     -c -o orsa_body.lo `test -f 'orsa_body.cc' || echo './'`orsa_body.cc
source='orsa_coord.cc' object='orsa_coord.lo' libtool=yes \
	depfile='.deps/orsa_coord.Plo' tmpdepfile='.deps/orsa_coord.TPlo' \
	depmode=gcc3 /bin/sh ../../depcomp \
	/bin/sh ../../libtool --tag=CXX --mode=compile mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./..  -DQT_THREAD_SUPPORT  -D_REENTRANT  -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include     -c -o orsa_coord.lo `test -f 'orsa_coord.cc' || echo './'`orsa_coord.cc
source='orsa_interaction.cc' object='orsa_interaction.lo' libtool=yes \
	depfile='.deps/orsa_interaction.Plo' tmpdepfile='.deps/orsa_interaction.TPlo' \
	depmode=gcc3 /bin/sh ../../depcomp \
	/bin/sh ../../libtool --tag=CXX --mode=compile mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./..  -DQT_THREAD_SUPPORT  -D_REENTRANT  -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include     -c -o orsa_interaction.lo `test -f 'orsa_interaction.cc' || echo './'`orsa_interaction.cc
mkdir .libs
 mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./.. -DQT_THREAD_SUPPORT -D_REENTRANT -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include -c orsa_secure_math.cc -MT orsa_secure_math.lo -MD -MP -MF .deps/orsa_secure_math.TPlo  -fPIC -DPIC -o .libs/orsa_secure_math.o
 mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./.. -DQT_THREAD_SUPPORT -D_REENTRANT -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include -c orsa_interaction.cc -MT orsa_interaction.lo -MD -MP -MF .deps/orsa_interaction.TPlo  -fPIC -DPIC -o .libs/orsa_interaction.o
 mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./.. -DQT_THREAD_SUPPORT -D_REENTRANT -g -Wall -W -pipe -ftemplate-depth-64 -O3 -fno-exceptions -funroll-loops -fstrict-aliasing -fno-gcse -I/usr/include -c orsa_body.cc -MT orsa_body.lo -MD -MP -MF .deps/orsa_body.TPlo  -fPIC -DPIC -o .libs/orsa_body.o
 mpiCC -DHAVE_CONFIG_H -I. -I. -I../../src -I./misc -I./.. -DQT_THREAD_SUPPORT -D_R

Comment 2 Milos Jakubicek 2008-09-10 14:11:21 UTC
Fixed, I also added missing Requires: for the -devel subpackage, I forgot to check this previously :(

New SRPM: http://mjakubicek.fedorapeople.org/orsa/orsa-0.7.0-2.fc9.src.rpm
New spec file: http://mjakubicek.fedorapeople.org/orsa/orsa.spec
New Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=817565

Comment 3 Lubomir Rintel 2008-09-12 05:48:30 UTC
Thanks! Seems awesome now!

APPROVED

Comment 4 Milos Jakubicek 2008-09-14 16:41:57 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: orsa
Short Description: Orbit Reconstruction, Simulation and Analysis
Owners: mjakubicek
Branches: F-8 F-9
InitialCC: mmahut

Comment 5 Kevin Fenzi 2008-09-14 22:28:06 UTC
cvs done.

Comment 6 Fedora Update System 2008-09-15 13:02:07 UTC
orsa-0.7.0-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/orsa-0.7.0-2.fc9

Comment 7 Fedora Update System 2008-09-16 23:20:25 UTC
orsa-0.7.0-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update orsa'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-8083

Comment 8 Fedora Update System 2008-09-23 14:02:29 UTC
orsa-0.7.0-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/orsa-0.7.0-2.fc8

Comment 9 Fedora Update System 2008-09-25 00:15:34 UTC
orsa-0.7.0-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update orsa'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-8271

Comment 10 Fedora Update System 2008-10-03 22:36:02 UTC
orsa-0.7.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2008-10-16 02:07:24 UTC
orsa-0.7.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.