Spec URL: http://huzaifas.fedorapeople.org/spec/openvas-libraries.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/openvas-libraries-1.0.1-1.fc10.src.rpm Description: Support libraries for Open Vulnerability Assessment (OpenVAS) Server Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=815186 http://koji.fedoraproject.org/koji/taskinfo?taskID=815193 http://koji.fedoraproject.org/koji/taskinfo?taskID=815203
Updated the rpm to newer upstream release and made spec file changes [huzaifas@localhost SPECS]$ rpmlint ../RPMS/i386/openvas-libraries-1.0.2-1.fc10.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [huzaifas@localhost SPECS]$ rpmlint ../SRPMS/openvas-libraries-1.0.2-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. SPEC: http://huzaifas.fedorapeople.org/spec/openvas-libraries.spec SRPMS:http://huzaifas.fedorapeople.org/srpms/openvas-libraries-1.0.2-1.fc10.src.rpm Parag all yours now :)
Suggestions:- 1) Group tag for openvas-libraries should be System Environment/Libraries 2) description for -devel should be %description devel openvas-libraries-devel contains development libraries and headers for use with openvas-libraries. 3) As I see that nearly all source file headers have license text, license tag should be GPLv2+
can you post updated SRPM?
yep. sorry i had to reinstall my laptop, will do that today :)
SPEC: http://huzaifas.fedorapeople.org/spec/openvas-libraries.spec SRPM: http://huzaifas.fedorapeople.org/srpms/openvas-libraries-1.0.2-2.fc8.src.rpm Sorry for the delay.
+ is OK - is NEED work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=876684 + rpmlint is silent for SRPM - rpmlint is NOT silent for RPM. openvas-libraries.i386: W: incoherent-version-in-changelog 1.0-2-2 1.0.2-2.fc10 ==> correct it at time of cvs import. + source files match upstream url 9113c17581ffec1b1c490896b63422f1 openvas-libraries-1.0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package openvas-libraries-1.0.2-2.fc10 -> Provides: libopenvas.so.1 libopenvas_hg.so.1 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libgnutls.so.26 libgnutls.so.26(GNUTLS_1_4) libnsl.so.1 libopenvas.so.1 libopenvas_hg.so.1 libpcap.so.0.9 libresolv.so.2 libresolv.so.2(GLIBC_2.0) libresolv.so.2(GLIBC_2.2) libresolv.so.2(GLIBC_2.9) libutil.so.1 rtld(GNU_HASH) + Package openvas-libraries-devel-1.0.2-2.fc10 -> Requires: /bin/sh libopenvas.so.1 libopenvas_hg.so.1 APPROVED.
can you request cvs here?
New Package CVS Request ======================= Package Name: openvas-libraries Short Description: Support libraries for Open Vulnerability Assessment (OpenVAS) Server Owners: huzaifas Branches: F-9 F-10 InitialCC:
cvs done.
Can you build this package for requested branches?
on it now
build now, closing.