Bug 461910 - Review Request: snes_ntsc - SNES NTSC video filtering library
Summary: Review Request: snes_ntsc - SNES NTSC video filtering library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Julian Sikorski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-11 11:44 UTC by David Timms
Modified: 2008-10-16 02:05 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-10-16 02:05:11 UTC
Type: ---
Embargoed:
belegdol: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)
diff between dribble spec and proposed fedora spec (2.37 KB, text/plain)
2008-09-11 11:45 UTC, David Timms
no flags Details

Description David Timms 2008-09-11 11:44:00 UTC
Spec URL: http://members.iinet.net.au/~timmsy/snes_ntsc/snes_ntsc.spec
SRPM URL:
http://members.iinet.net.au/~timmsy/snes_ntsc/snes_ntsc-0.2.2-3.fc9.src.rpm

Description: 
Super NES NTSC video filter. The main benefit is color mixing, as composite
video artifacts are less noticeable than on the NES. Accepts pixels in 16-bit
RGB or 15-bit BGR (native SNES format).
===
$ rpmlint snes_ntsc.spec ~/src/redhat/SRPMS/snes_ntsc-0.2.2-3.fc9.src.rpm ~/src/redhat/RPMS/i386/snes*.rpm
snes_ntsc-demos.i386: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 David Timms 2008-09-11 11:45:55 UTC
Created attachment 316427 [details]
diff between dribble spec and proposed fedora spec

Comment 2 Julian Sikorski 2008-09-16 09:32:13 UTC
The differences seem to be cosmetic, I'll take a look later if nobody beats me to it.

Comment 3 Julian Sikorski 2008-09-18 20:22:18 UTC
- MUST: rpmlint output:
  snes_ntsc-demos.x86_64: W: no-documentation
  5 packages and 0 specfiles checked; 0 errors, 1 warnings.
  This can be safely ignored.
- MUST: The package is named according to the Package Naming Guidelines .
- MUST: The spec file name matches the base package %{name}.
- MUST: The package meets the Packaging Guidelines .
- MUST: The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
- MUST: The License field in the package spec file matches the actual license.
- MUST: The file containing the text of the license(s) for the package is included in %doc.
- MUST: The spec file is written in American English.
- MUST: The spec file for the package is legible.
- MUST: Source matches upstream: 07b10506e4d57b0ef312eedaae537cc2  snes_ntsc-0.2.2.zip
- MUST: Package builds on x86_64
- MUST: Package builds fine on i386, x86_64, ppc, ppc64.
- MUST: BuildRequires correct.
- MUST: No locale present.
- MUST: ldconfig scriptlets correct.
- MUST: Not relocatable.
- MUST: Directories ownership correct.
- MUST: No duplicates in %files.
- MUST: Permissions correct.
- MUST: %clean section present.
- MUST: Macros are used consistently.
- MUST: Package contains code.
- MUST: No -doc subpackage necessary.
- MUST: %doc not required at runtime.
- MUST: Header files are in a -devel package.
- MUST: No static libraries.
- MUST: No pkgconfig files present.
- MUST: library with .so suffix in -devel package.
- MUST: -devel package Requires: %{name} = %{version}-%{release}
- MUST: No libtool archives present.
- MUST: Not a GUI application.
- MUST: Ownership does not overlap.
- MUST: %buildroot cleaned at the beginning %install.
- MUST: Filenames are UTF-8.

This package is approved by me.

Comment 4 David Timms 2008-09-20 14:18:37 UTC
Julian: thanks for the review ;)

New Package CVS Request
=======================
Package Name: snes_ntsc
Short Description: SNES NTSC video filtering library
Owners: dtimms
Branches: F-8 F-9 EL-5
InitialCC: belegdol

Comment 5 Kevin Fenzi 2008-09-21 00:26:08 UTC
cvs done.

Comment 6 Fedora Update System 2008-09-21 08:21:42 UTC
snes_ntsc-0.2.2-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/snes_ntsc-0.2.2-3.fc9

Comment 7 Fedora Update System 2008-09-21 08:21:46 UTC
snes_ntsc-0.2.2-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/snes_ntsc-0.2.2-3.fc8

Comment 8 Fedora Update System 2008-09-25 00:01:54 UTC
snes_ntsc-0.2.2-3.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snes_ntsc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-8188

Comment 9 Fedora Update System 2008-09-25 00:14:24 UTC
snes_ntsc-0.2.2-3.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snes_ntsc'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-8265

Comment 10 Fedora Update System 2008-10-16 02:05:09 UTC
snes_ntsc-0.2.2-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2008-10-16 02:05:17 UTC
snes_ntsc-0.2.2-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.