Bug 461976 (perl-Gtk2-ImageView) - Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget
Summary: Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image...
Alias: perl-Gtk2-ImageView
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
: 453772 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2008-09-11 17:52 UTC by Tom "spot" Callaway
Modified: 2013-01-10 04:48 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-09-12 14:31:06 UTC
Type: ---
jkeating: fedora-review+
tcallawa: fedora-cvs+

Attachments (Terms of Use)

Description Tom "spot" Callaway 2008-09-11 17:52:02 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/new/perl-Gtk2-ImageView.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/perl-Gtk2-ImageView-0.04-1.fc10.src.rpm
Perl bindings to the GtkImageView image viewer widget. Find out more about
GtkImageView at http://trac.bjourne.webfactional.com/. The Perl bindings follow
the C API very closely, and the C reference should be considered the canonical

Note: You'll need this updated perl-Glib package to build/use this:

Accordingly, this is a rawhide only item (F10+).

Comment 1 Mamoru TASAKA 2008-09-11 18:10:50 UTC
Currently I am waiting for a reply from the submitter on bug 453772 .

Comment 2 Tom "spot" Callaway 2008-09-11 18:22:18 UTC
I didn't see that one, apologies. Jesse Keating pointed out that we had broken dependencies in rawhide, so I whipped up a package to fix it.

Comment 3 Jesse Keating 2008-09-11 21:33:59 UTC
I tried installing all the BuildRequires, including the listed koji build, but when I tried to build the srpm I got:

+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor 'OPTIMIZE=-O2 -g'
Can't locate Gtk2.pm in @INC (@INC contains: /usr/lib64/perl5/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/5.10.0 /usr/local/lib64/perl5/site_perl/5.10.0/x86_64-linux-thread-multi /usr/local/lib/perl5/site_perl/5.10.0 /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.10.0 /usr/lib/perl5/vendor_perl /usr/local/lib/perl5/site_perl /usr/local/lib64/perl5/site_perl .) at (eval 9) line 1.
BEGIN failed--compilation aborted at (eval 9) line 1.

Checking if your kit is complete...
Looks good
MakeMaker FATAL: prerequisites not found.
    Gtk2 not installed

Please install these modules first and rerun 'perl Makefile.PL'.
error: Bad exit status from /var/tmp/rpm-tmp.cA3OLn (%build)

Looks like a missing BuildRequire on perl-Gtk2 (or the proper perl module therein)

Other than that, it builds, passes rpmlint, and the spec looks fine regarding both packaging guidelines and the specific perl guidelines.

Correct the missing BuildRequires and this is approved.

Comment 4 Tom "spot" Callaway 2008-09-12 14:15:55 UTC
New Package CVS Request
Package Name: perl-Gtk2-ImageView
Short Description: Perl bindings to the GtkImageView image viewer widget
Owners: spot
Branches: F-8 F-9 devel
InitialCC: perl-sig

... and it's done.

Comment 5 Tom "spot" Callaway 2008-09-12 14:31:06 UTC
Built in rawhide.

Comment 6 Mamoru TASAKA 2008-09-12 14:43:00 UTC
*** Bug 453772 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.