Bug 462155 - convert_pam_mount_conf.pl breaks in presence of lsof in /etc/security/pam_mount.conf
Summary: convert_pam_mount_conf.pl breaks in presence of lsof in /etc/security/pam_mou...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: pam_mount
Version: 8
Hardware: All
OS: Linux
medium
high
Target Milestone: ---
Assignee: Till Maas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-13 02:00 UTC by Stephen P. Schaefer
Modified: 2008-09-16 23:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-09-16 23:24:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Stephen P. Schaefer 2008-09-13 02:00:36 UTC
Description of problem:
/usr/bin/convert_pam_mount_conf.pl does not define the routine callback_lsof, so that when it encounters an lsof file system definition in /etc/security/pam_mount.conf (e.g.

lsof /usr/sbin/lsof %(MNTPT)

)

it dies, leaving an invalid /etc/security/pam_mount.conf.xml file.  This action occurs during the pam_mount package update.

Version-Release number of selected component (if applicable):
0.47-1

How reproducible:
Always.

Steps to Reproduce:
1. configure pam_mount as described with version pam_mount-0.18-2
2. yum update
3.
  
Actual results:

Invalid /etc/security/pam_mount.conf.xml file.  No more home directory.

Expected results:

Valid /etc/security/pam_mont.conf.xml file.  Home directory present.

Additional info:

The convert_pam_mount_conf.pl script worked after I commented out the lsof mount from /etc/security/pam_mount.conf.  I don't remember putting that there myself; I suspect everyone has it.  I'm not familiar with the lsof file sytem, and it appears inessential to the system.  The following patch abandons lsof support:

--- /usr/bin/convert_pam_mount_conf.pl  2008-09-04 23:28:34.000000000 -0400
+++ convert_pam_mount_conf.pl   2008-09-12 21:55:15.000000000 -0400
@@ -81,6 +81,11 @@
        $writer->emptyTag("fsckloop", "device" => $fields[1]);
 }
 
+sub callback_lsof
+{
+       print STDERR "lsof no longer supported";
+}
+
 sub callback_luserconf
 {
        my @fields = @_;

Comment 1 Till Maas 2008-09-13 11:02:06 UTC
Thanks, I reported it to upstream and will create an update, soon.

http://sourceforge.net/tracker/index.php?func=detail&aid=2108822&group_id=41452&atid=430593

Comment 2 Fedora Update System 2008-09-13 11:46:19 UTC
pam_mount-0.48-2.fc9,libHX-1.25-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/pam_mount-0.48-2.fc9,libHX-1.25-1.fc9

Comment 3 Fedora Update System 2008-09-13 11:52:35 UTC
pam_mount-0.48-2.fc8,libHX-1.25-1.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/pam_mount-0.48-2.fc8,libHX-1.25-1.fc8

Comment 4 Fedora Update System 2008-09-16 23:24:18 UTC
pam_mount-0.48-2.fc9, libHX-1.25-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2008-09-16 23:30:05 UTC
pam_mount-0.48-2.fc8, libHX-1.25-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.