Hide Forgot
Spec URL: http://www.xs4all.nl/~iarnell/fedora/perl-Cache-FastMmap.spec SRPM URL: http://www.xs4all.nl/~iarnell/fedora/perl-Cache-FastMmap-1.28-1.fc9.src.rpm Description: In multi-process environments (eg mod_perl, forking daemons, etc), it's common to want to cache information, but have that cache shared between processes. Many solutions already exist, and may suit your situation better. This package is required for perl-Catalyst-Plugin-Session-Store-FastMmap This is my first package, so I am also seeking a sponsor.
A couple comments -- and, looks good, especially for a first package :) There are tests that are skipped due to the non-presence of certain modules. perl(GTop) and perl(Compress::Zlib) should be added as buildrequires to enable those tests to be run on the buildsystem. (In general, all additional modules required to enable optional tests should be buildrequire'ed; the exception is for "author" or "subjective" tests, like Test::Pod::Coverage, Test::Perl::Critic, or Test::Kwalitee.) Aside from that, a scratch build looked good: http://koji.fedoraproject.org/koji/taskinfo?taskID=825581 %description isn't the best, but then, it's what the module author used. Update to include the missing br's listed above, and I'll take a closer look at this one. Do you have any other packages up for review?
Thanks for the quick response. Updated with the additional BRs - although Compress::Zlib seems to get pulled into the build automatically, I guess it's good form to explicitly state it in case things change in future. New Spec: http://www.xs4all.nl/~iarnell/fedora/perl-Cache-FastMmap.spec New SRPM: http://www.xs4all.nl/~iarnell/fedora/perl-Cache-FastMmap-1.28-2.fc9.src.rpm These are the only two packages I've submitted so far - I wanted to get feedback from these before ploughing ahead with any more.
Looks like this got dropped somehow. I am still seeing a test skipped due to missing Compress::Zlib. I read comment #2 to say that you were going to include it, but I don't see it there and I can verify that it is not pulled into the build environment by any other package. I'm also getting an rpmlint complaint: perl-Cache-FastMmap.x86_64: W: incoherent-version-in-changelog 2.28-1 ['1.28-2.fc10', '1.28-2'] and indeed the spec in the src.rpm linked above has a changelog entry with version "2.28-1" instead of "1.28-2". But the spec file linked above does not seem to have the above issues, so I'm a bit confused. Did you build the src.rpm and then modify the spec further?
I'm confused too - I certainly never modify spec files without automatically rebuilding and testing corresponding rpms. I can't rule out copying the wrong src.rpm to the server though - I've replaced it with a fresh rebuild (and redownloaded and rechecked that I've really uploaded the correct thing this time).
Yes, that's better, thanks. This package looks fine. Please go ahead and get your account set up, accept the CLA and apply for membership in the packager group. I will sponsor you. * source files match upstream: aa819d16345b537a88b539f5afe9a90b3ddf208a21ea5f89f0bc0850fe0a05d5 Cache-FastMmap-1.28.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: CImpl.so()(64bit) perl(Cache::FastMmap) = 1.28 perl(Cache::FastMmap::CImpl) = 1.28 perl-Cache-FastMmap = 1.28-2.fc10 perl-Cache-FastMmap(x86-64) = 1.28-2.fc10 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Cache::FastMmap::CImpl) perl(XSLoader) perl(bytes) perl(constant) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=14, Tests=315, 23 wallclock secs ( 0.06 usr 0.02 sys + 4.30 cusr 0.67 csys = 5.05 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED
Thanks Jason. Account is already set up (iarnell) and CLA accepted.
Oh, you attempted to join some time ago. That shouldn't be done until you actually have a sponsor. In any case, its set up now; you should be able to make your CVS request. Also, you seem to have left your real name out of your account information, which is why I didn't find you in the database.
I was just following the instructions on http://fedoraproject.org/wiki/PackageMaintainers/Join - maybe section 1.1.9.4 should be moved to section 1.1.11? 1.1.7 Create Your Review Request 1.1.8 Watch for Feedback 1.1.9 Get a Fedora Account ... 1.1.9.4.1 In the table, look for the packager group, and click Apply under Status. 1.1.10 Install the Client Tools (Koji) 1.1.11 Get Sponsored As for real name, it's definitely there in the account details.
New Package CVS Request ======================= Package Name: perl-Cache-FastMmap Short Description: Uses an mmap'ed file to act as a shared memory interprocess cache Owners: iarnell Branches: F-9 F-10 InitialCC: perl-sig
CVS Done
perl-Cache-FastMmap-1.28-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Cache-FastMmap-1.28-2.fc9
perl-Cache-FastMmap-1.28-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Cache-FastMmap-1.28-2.fc10
perl-Cache-FastMmap-1.28-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-Cache-FastMmap-1.28-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Cache-FastMmap New Branches: EL-4 EL-5 Owners: iarnell InitialCC: perl-sig
cvs done.
perl-Cache-FastMmap-1.34-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Cache-FastMmap-1.34-5.el5
perl-Cache-FastMmap-1.34-5.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/perl-Cache-FastMmap-1.34-5.el4
perl-Cache-FastMmap-1.34-5.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
perl-Cache-FastMmap-1.34-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Cache-FastMmap New Branches: epel7 Owners: psabata InitialCC: perl-sig
Git done (by process-git-requests).
Thank you.