Bug 462474 - fipshmac could check its input
fipshmac could check its input
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: fipscheck (Show other bugs)
All Linux
medium Severity medium
: rc
: ---
Assigned To: Tomas Mraz
Depends On:
  Show dependency treegraph
Reported: 2008-09-16 11:25 EDT by Jakub Hrozek
Modified: 2009-01-21 13:35 EST (History)
1 user (show)

See Also:
Fixed In Version: fipscheck-1.0.3-1.el5
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-01-21 13:35:04 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Jakub Hrozek 2008-09-16 11:25:43 EDT
Description of problem:
fipshmac does not check its input for correctness, leading to confusing situations like:
# fipshmac --help
# echo $?
# ls -l .--help.hmac
-rw-r--r-- 1 root root 65 Sep 16 16:48 .--help.hmac

Version-Release number of selected component (if applicable):

Actual results:
Return code 0, the file.--help is generated

Expected results:
Some kind of error message or at least return code != 0

This is kinda cornercase I guess, b/c looking at filehmac.c, what probably happens is that a call is done to /usr/sbin/prelink --verify --help - so instead of expected contents of unprelinked binary, you get a prelink help message from the pipe :-]
Comment 1 Tomas Mraz 2009-01-21 13:35:04 EST
fipshmac does not call prelink anymore. So it will return exit code 4 on nonexisting files (such as --help).

Note You need to log in before you can comment on or make changes to this bug.