Spec URL: http://rishi.fedorapeople.org/ldtp.spec SRPM URL: http://rishi.fedorapeople.org/ldtp-1.3.0-1.fc9.src.rpm Description: Linux Desktop (GUI Application) Testing Project (LDTP) is aimed at producing high quality test automation framework and cutting-edge tools that can be used to test Linux Desktop and improve it. It uses the Accessibility libraries to poke through the application's user interface. The framework also has tools to record test-cases based on user-selection on the application.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=832881
will review in a while. Will wait till python-statgrab review is complete.
pystatgrab is approved. So, I will start the review.
[rpmbuild@rocky-test i386]$ rp ldtp-1.3.0-1.fc10.i386.rpm ldtp.i386: E: non-executable-script /usr/lib/python2.5/site-packages/ldtplib/__init__.py 0644 ldtp.i386: E: non-executable-script /usr/lib/python2.5/site-packages/ldtplib/ldtprecorder.py 0644 ldtp.i386: E: non-executable-script /usr/lib/python2.5/site-packages/ldtplib/libldtpcodegen.py 0644 ldtp.i386: E: non-executable-script /usr/lib/python2.5/site-packages/ldtplib/ldtpcommon.py 0644 1 packages and 0 specfiles checked; 4 errors, 0 warnings. May be use sed -e '/^#!\//,1 d' -i %{buildroot}/%{python_sitearch}/ldtplib/<file> [rpmbuild@rocky-test SRPMS]$ rp -i ldtp-1.3.0-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [rpmbuild@rocky-test i386]$ rp -i ldtp-debuginfo-1.3.0-1.fc10.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Builds fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=900276 Review ldtp rpmlint - x needs work naming - OK packaging guidelines - OK license - OK license field - OK spec file legible and written in American English - OK source matches upstream - OK (md5sum) architectures supported - OK build Require - OK locale - N/A directories owned - OK no duplicate files - OK permissions - OK %install and %check have " rm -rf %{buildroot} " - OK description and summary - OK
> May be use > sed -e '/^#!\//,1 d' -i %{buildroot}/%{python_sitearch}/ldtplib/<file> $ sed -i -e '1d' $FILE ... was enough enough. :-) Upstream has agreed to fix it in the next release. Spec: http://rishi.fedorapeople.org/ldtp.spec SRPM: http://rishi.fedorapeople.org/ldtp-1.3.0-2.fc9.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=459010 You need to build it after above one gets imported and build. APPROVED
May you import it? :)
New Package CVS Request ======================= Package Name: ldtp Short Description: Desktop testing framework Owners: rishi Branches: F-9 F-10 InitialCC:
CVS Done