Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 463425

Summary: .discinfo version and .treeinfo version do not match
Product: Red Hat Enterprise Linux 5 Reporter: James Laska <jlaska>
Component: relengAssignee: Dennis Gregorovic <dgregor>
Status: CLOSED ERRATA QA Contact: Alexander Todorov <atodorov>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.4CC: atodorov, borgan, bpeck, clumens, dmach, jgranado, jlaska, jturner
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 12:01:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James Laska 2008-09-23 12:12:22 UTC
# curl http://porkchop.redhat.com/nightly/RHEL5.3-Server-20080919.nightly/tree-i386/.discinfo

1221803353.466553
Red Hat Enterprise Linux Server 5.3
i386
ALL
Server/base
Server/RPMS
Server/pixmaps


# curl http://porkchop.redhat.com/nightly/RHEL5.3-Server-20080919.nightly/tree-i386/.treeinfo

[general]
family = Red Hat Enterprise Linux Server
timestamp = 1221802175.49
totaldiscs = 1
version = 5
discnum = 1
packagedir = Server
arch = i386

...


Should the fix that changed the .discinfo version should be carried forward into the version in .treeinfo?

Comment 1 Dennis Gregorovic 2008-09-23 14:38:07 UTC
Just to clarify, is this what you would expect in .treeinfo?

[general]
family = Red Hat Enterprise Linux Server
timestamp = 1221802175.49
totaldiscs = 1
version = 5
update = 3
discnum = 1
packagedir = Server
arch = i386

Currently the .treeinfo file is created by anaconda and distill just copies it.  I could add logic to distill to tweak the .treeinfo file, but I would be in favor of making the change in anaconda itself.  What do you think?

Comment 2 James Laska 2008-09-23 14:48:47 UTC
I'd prefer keeping the existing fields (and not adding a new key 'update') ... but I know bpeck may want something different?

[general]
family = Red Hat Enterprise Linux Server
timestamp = 1221802175.49
totaldiscs = 1
version = 5.3

Yeah Dennis, I think you are right in that anaconda should just write the product info that is passed in to builddistro.  Is anaconda mk-images being supplied with the right information in order to write out the version string as noted above?  Or are additional parameters required?

Comment 3 Dennis Gregorovic 2008-09-23 15:01:46 UTC
I pass "--version '5'" to buildinstall.  I could modify that to 5.3 or include a new parameter.  If I just change it to "--version '5.3'" then we _may_ be able to get away without making any changes to buildinstall.  However, I don't know enough about the buildinstall scripts to say if that change would cause breakage elsewhere.

Comment 4 James Laska 2008-09-23 15:40:30 UTC
Adding jgranado as Joel instrumented the anaconda  .treeinfo parsing for RHEL5.2

Comment 5 Joel Andres Granados 2008-09-24 09:14:31 UTC
The "5.3" argument should be fine.  Be aware that you will also be changing the /root/.buildstamp file.

Comment 7 Bill Peck 2009-04-13 15:46:04 UTC
So far rhel5.4 builds are not showing the correct version.  Any ETA on this?

version = 5.4 would be fine

Comment 8 Dennis Gregorovic 2009-04-13 18:36:05 UTC
change checked into distill.

Comment 12 errata-xmlrpc 2009-09-02 12:01:11 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-1400.html