Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 463817

Summary: gfs_fsck can't decide which bitmap to fix
Product: Red Hat Enterprise Linux 5 Reporter: Nate Straz <nstraz>
Component: gfs-utilsAssignee: Robert Peterson <rpeterso>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3CC: cfeist, edamato, jkortus
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 11:01:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to fix the problem none

Description Nate Straz 2008-09-24 19:54:55 UTC 
Description of problem:

While running gfs_fsck, if you don't answer y or n to a response, it'll ask you about a different block number next time it asks.

Fix bitmap for block 215211101? (y/n) y
Succeeded.
ondisk and fsck bitmaps differ at block 215211102
Fix bitmap for block 215211102? (y/n) 
Bad response, please type 'y' or 'n'.
Fix bitmap for block 18446744073709551615? (y/n) 
Bad response, please type 'y' or 'n'.
Fix bitmap for block 47351378903632? (y/n) 
Bad response, please type 'y' or 'n'.
Fix bitmap for block 241450444864? (y/n) 
Bad response, please type 'y' or 'n'.
Fix bitmap for block 0? (y/n) 
... etc ...

Version-Release number of selected component (if applicable):
gfs-utils-0.1.18-1.el5

How reproducible:
easily

Steps to Reproduce:
1. corrupt your file system
2. run gfs_fsck
3. don't answer
Comment 1 Robert Peterson 2008-09-25 20:25:24 UTC 
Created attachment 317723 [details]
Patch to fix the problem

This patch was tested and found to fix the problem.
We needed to do a va_start every time we go through the query loop,
otherwise our arguments are left in an undefined state.
Comment 2 Robert Peterson 2008-09-25 20:27:37 UTC 
Easy fix; requesting flags for inclusion into 5.4 or 5.3. if
management decides to go that route.
Comment 3 Robert Peterson 2008-09-25 20:40:23 UTC 
I pushed the fix to the master and STABLE2 branches of our cluster
git tree.  Waiting for flags before doing the RHEL5 branch.
Comment 5 Robert Peterson 2008-12-16 14:58:41 UTC 
I pushed the patch to the RHEL5 branch of the cluster git tree now
for inclusion into 5.4.  Changing status to Modified.
Comment 7 Jaroslav Kortus 2009-07-20 16:05:03 UTC 
verified with gfs-utils-0.1.20-1.el5

part of gfs_fsck output:
 Fix bitmap for block 85? (y/n) x
 Bad response, please type 'y' or 'n'.
 Fix bitmap for block 85? (y/n)
Comment 10 errata-xmlrpc 2009-09-02 11:01:18 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1336.html