Bug 463848 - easyfix: spec file portability
easyfix: spec file portability
Status: CLOSED DEFERRED
Product: Fedora
Classification: Fedora
Component: cups-pdf (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Remi Collet
Fedora Extras Quality Assurance
: EasyFix
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-24 17:03 EDT by R P Herrold
Modified: 2008-09-25 16:27 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-09-25 16:27:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description R P Herrold 2008-09-24 17:03:07 EDT
Description of problem:

The spec file contains a incompletely specified conditional test.
It needs a leading '0' to avoid a failed compare; trifvial patch in teh Additional Information section



Version-Release number of selected component (if applicable):

cups-pdf-2.4.8-1.fc10.src.rpm

How reproducible:

   87  cp cups-pdf.spec-ORIG cups-pdf.spec
   88  rpmbuild -ba  cups-pdf.spec


Actual results:

a failed build

Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/cups-pdf-2.4.8-1-root-herrold
error: Installed (but unpackaged) file(s) found:
   /etc/cups/cups-pdf.conf
   /usr/lib/cups/backend/cups-pdf
   /usr/share/cups/model/CUPS-PDF.ppd


RPM build errors:
    /home/herrold/build/gnomint/cups-pdf.spec:149: parseExpressionBoolean returns -1
    Installed (but unpackaged) file(s) found:
   /etc/cups/cups-pdf.conf
   /usr/lib/cups/backend/cups-pdf
   /usr/share/cups/model/CUPS-PDF.ppd
[herrold@dhcp-233 gnomint]$


Expected results:

a clean build


Additional info:


patch inline:
[herrold@dhcp-233 gnomint]$ diff -u cups-pdf.spec-ORIG cups-pdf.spec
--- cups-pdf.spec-ORIG  2008-09-24 16:57:46.000000000 -0400
+++ cups-pdf.spec       2008-09-24 16:57:03.000000000 -0400
@@ -146,7 +146,7 @@
 # First install : create the printer if cupsd is running
 if [ "$1" -eq "1" -a -f "%{_var}/run/cupsd.pid" ]
 then
-%if %{?fedora}%{?rhel} < 5
+%if 0%{?fedora}%{?rhel} < 5
     # Restart CUPS on old Fedora/RHEL to discover the new "backend"
     /sbin/service cups condrestart
 %endif
[herrold@dhcp-233 gnomint]$
Comment 1 Remi Collet 2008-09-25 16:27:19 EDT
This issue doesn't affect Fedora nor Epel build.

I will fix it on a next build (new upstream release).

Note You need to log in before you can comment on or make changes to this bug.