Spec URL: http://lucilanga.fedorapeople.org/memtester.spec SRPM URL: http://lucilanga.fedorapeople.org/memtester-4.0.8-1.fc9.src.rpm Description: memtester is a utility for testing the memory subsystem in a computer to determine if it is faulty.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of package: 1330edaa60e0d797b83df51a56bba377db9223fc memtester-4.0.8.tar.gz [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. === Issues === 1. I am not sure about the necessity of the last patch (the one affecting conf-cc). Anyway, please drop the "-O2" flag, RPM_OPTS contains all that is needed. 2. It would be nice if you would be preserve the timestamps of the documentation files that you modify (BUGS, README). A simple call to touch -r is all that is needed ================ *** APPROVED *** but please adjust your patch to take into consideration the above mentioned first issue. ================
Thank you. (In reply to comment #1) > === Issues === > 1. I am not sure about the necessity of the last patch (the one affecting > conf-cc). Anyway, please drop the "-O2" flag, RPM_OPTS contains all that is > needed. modifying conf-cc was no longer needed so I removed it from the patch > 2. It would be nice if you would be preserve the timestamps of the > documentation files that you modify (BUGS, README). A simple call to touch -r > is all that is needed i've used touch -r for README and passing -k flag to BUGS line.
New Package CVS Request ======================= Package Name: memtester Short Description: Utility to test for faulty memory subsystem Owners: lucilanga Branches: F-8 F-9 EL-5
cvs done
memtester-4.0.8-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/memtester-4.0.8-2.fc8
memtester-4.0.8-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/memtester-4.0.8-2.fc9
memtester-4.0.8-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
memtester-4.0.8-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.