Red Hat Bugzilla – Bug 464458
Review Request: greadelf - GUI frontend to elfinfo and eu-readelf
Last modified: 2008-11-11 02:53:16 EST
Spec URL: http://ashokdas.fedorapeople.org/greadelf.spec SRPM URL: http://ashokdas.fedorapeople.org/greadelf-0.4-1.fc9.src.rpm Description: GUI frontend for elfinfo and eu-readelf.
Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=849316 + rpmlint is silent for SRPM and RPM. + source files match upstream. 148744d64f5d82d1e9f39b5029b624c6 greadelf-0.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly. + GUI app. Suggestions:- You many like to either build with elfinfo dependency at time of importing this package to CVS once elfinfo package appears in rawhide or you can also add this dependency next time you build this package again. APPROVED.
New Package CVS Request ======================= Package Name: greadelf Short Description: GUI frontend for elfinfo and eu-readelf. Owners: ashokdas Branches: F-9 InitialCC:
cvs done, Removed the "." at the end of the Description.
greadelf-0.4-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/greadelf-0.4-1.fc9
greadelf-0.4-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: greadelf New Branches: EL-5
Package Change Request ====================== Package Name: greadelf New Branches: EL-5 Owners: ashokdas paragn
cvs done
Thanks Jens for quick cvs.