Bug 464458 - Review Request: greadelf - GUI frontend to elfinfo and eu-readelf
Summary: Review Request: greadelf - GUI frontend to elfinfo and eu-readelf
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-29 08:54 UTC by ashok
Modified: 2008-11-11 07:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-10-03 22:33:33 UTC
Type: ---
Embargoed:
panemade: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description ashok 2008-09-29 08:54:40 UTC
Spec URL: http://ashokdas.fedorapeople.org/greadelf.spec
SRPM URL: http://ashokdas.fedorapeople.org/greadelf-0.4-1.fc9.src.rpm
Description: GUI frontend for elfinfo and eu-readelf.

Comment 1 Parag AN(पराग) 2008-09-29 09:05:29 UTC
Review:
+ package builds in mock (rawhide i386).
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=849316
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
148744d64f5d82d1e9f39b5029b624c6  greadelf-0.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

Suggestions:- 
   You many like to either build with elfinfo dependency at time of importing this package to CVS once elfinfo package appears in rawhide or you can also add this dependency next time you build this package again.

APPROVED.

Comment 2 ashok 2008-09-29 09:34:30 UTC
New Package CVS Request
=======================
Package Name: greadelf
Short Description: GUI frontend for elfinfo and eu-readelf.
Owners: ashokdas
Branches: F-9
InitialCC:

Comment 3 Huzaifa S. Sidhpurwala 2008-09-30 04:23:25 UTC
cvs done,
Removed the "." at the end of the Description.

Comment 4 Fedora Update System 2008-10-03 06:06:06 UTC
greadelf-0.4-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/greadelf-0.4-1.fc9

Comment 5 Fedora Update System 2008-10-03 22:33:31 UTC
greadelf-0.4-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Parag Nemade 2008-11-11 06:13:06 UTC
Package Change Request
======================
Package Name: greadelf
New Branches: EL-5

Comment 7 Parag Nemade 2008-11-11 06:41:39 UTC
Package Change Request
======================
Package Name: greadelf
New Branches: EL-5
Owners: ashokdas paragn

Comment 8 Jens Petersen 2008-11-11 07:41:45 UTC
cvs done

Comment 9 Parag Nemade 2008-11-11 07:53:16 UTC
Thanks Jens for quick cvs.


Note You need to log in before you can comment on or make changes to this bug.