Bug 464760 - NM uses obsoleted "struct termio"
Summary: NM uses obsoleted "struct termio"
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Williams
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-09-30 10:53 UTC by Oliver Falk
Modified: 2009-04-17 14:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-09 20:24:46 UTC
Type: ---


Attachments (Terms of Use)
cvs diff to the specfile - needs to be adopted of course (1.45 KB, patch)
2008-09-30 10:53 UTC, Oliver Falk
no flags Details | Diff
Simple patch to use "struct termios" instead of (obsoleted) "struct termio" in nm-serial-device.c (545 bytes, patch)
2008-09-30 10:55 UTC, Oliver Falk
no flags Details | Diff

Description Oliver Falk 2008-09-30 10:53:34 UTC
Created attachment 318056 [details]
cvs diff to the specfile - needs to be adopted of course

While trying to compile NM-1:0.7.0-0.11.svn4022.2 on alpha, I ran into a compile error:

"""
nm-serial-device.c: In function 'nm_serial_device_open':
nm-serial-device.c:348: error: array subscript is above array bounds
nm-serial-device.c:349: error: array subscript is above array bounds
"""

After analysing the problem, I found out that stdbuf is defined as "struct termio". Take a look at termio.h:
"""
[oliver@kriek ~]$ cat /usr/include/termio.h 
/* Compatible <termio.h> for old `struct termio' ioctl interface.
   This is obsolete; use the POSIX.1 `struct termios' interface
   defined in <termios.h> instead.  */

#include <termios.h>
#include <sys/ioctl.h>
"""

A simple fix - at least for alpha - is to use "struct termios" instead (I'll include a patch!). However, I have not tested this on x86 or any other platform - this is up to you! :-)

Comment 1 Oliver Falk 2008-09-30 10:55:44 UTC
Created attachment 318057 [details]
Simple patch to use "struct termios" instead of (obsoleted) "struct termio"  in nm-serial-device.c

This needs to be tested on x86(_64), ppc and sparc... I don't know if it will work there as well.

Comment 2 Oliver Falk 2008-11-18 09:57:33 UTC
ping :-)

Comment 3 Niels Haase 2009-04-09 20:24:46 UTC
Thanks for the patch. But if you make changes to NetworkManager, create the patch using a Unified diff format (ie, diff -u) and mail the patch to the NetworkManager list (networkmanager-list@gnome.org). Thanks

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 4 Oliver Falk 2009-04-16 07:26:21 UTC
Oh great. For this answer I had to way half a year :-/

Comment 5 Dan Williams 2009-04-17 14:01:46 UTC
Upstream commit 31a34fa7ffbceb79d5e6c16158e5dcce285dcff1.  Sorry for the lag...


Note You need to log in before you can comment on or make changes to this bug.