Bug 465370 - kde4.sh micro-optimization
Summary: kde4.sh micro-optimization
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdelibs
Version: 10
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-02 21:54 UTC by Ville Skyttä
Modified: 2009-07-28 18:28 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-02-04 17:37:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
kde4.sh micro-optimization (769 bytes, patch)
2008-10-02 21:54 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2008-10-02 21:54:41 UTC
Created attachment 319299 [details]
kde4.sh micro-optimization

Here's a tiny optimization to kde4.sh: always avoid one stat of /etc/sysconfig/prelink, and also avoid grepping it if $KDE_IS_PRELINKED is already defined.

If accepted, should also be applied to kdelibs3's kde.sh.

(BTW, I wonder if grepping /etc/sysconfig/prelink is intentionally preferred over sourcing it and then testing $PRELINKING?  grepping might be a bit fragile.)

Comment 1 Steven M. Parrish 2008-10-03 23:13:17 UTC
Rex, Kevin, Than handle this with Fedora or bump upstream?

Comment 2 Kevin Kofler 2008-10-03 23:17:31 UTC
The kde4.sh script is part of Fedora packaging.

Comment 3 Bug Zapper 2008-11-26 03:29:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle.
Changing version to '10'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Steven M. Parrish 2009-01-10 15:10:01 UTC
We going to act on this or wontfix?

Comment 5 Rex Dieter 2009-01-10 16:17:38 UTC
yes, it's a worthwhile sh-specific improvement (dang, and I just touched on kde4.sh yesterday).

Comment 6 Ville Skyttä 2009-01-10 17:32:57 UTC
CVS ACLs allowed it so I committed this to kdelibs3 as 6:3.5.10-4 in devel (did not tag nor build).  kdelibs ACLs don't seem to allow me to do that.

When someone applies this to kde4.sh, while at it, the '-n "$QT_PLUGIN_PATH"' branch below could also be optimized a bit by invoking "kde4-config --path qtplugins" only once and reusing the result.

Comment 7 Steven M. Parrish 2009-02-04 17:27:44 UTC
Ping

Comment 8 Rex Dieter 2009-02-04 17:37:25 UTC
doh, forgot to close:

* Mon Jan 12 2009 Rex Dieter <rdieter> - 4.1.96-7
- Slight speedup to profile.d/kde.sh (#465370)

Comment 9 Fedora Update System 2009-07-26 08:45:22 UTC
kdelibs3-3.5.10-13.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/kdelibs3-3.5.10-13.fc10

Comment 10 Fedora Update System 2009-07-28 18:28:08 UTC
kdelibs3-3.5.10-13.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.