Bug 465482 - Review Request: hunspell-hsb - Upper Sorbian hunspell dictionaries
Summary: Review Request: hunspell-hsb - Upper Sorbian hunspell dictionaries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-03 15:07 UTC by Caolan McNamara
Modified: 2008-10-06 11:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-06 11:04:58 UTC
Type: ---
Embargoed:
panemade: fedora-review+
huzaifas: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2008-10-03 15:07:40 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-hsb.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-hsb-0.20060327.2-1.fc9.src.rpm
Description: Upper Sorbian hunspell dictionaries

Comment 1 Parag AN(पराग) 2008-10-06 08:14:30 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=863071
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
4a2cdc1bdd6e2e12d9e4e122c9f9cc84  upper_sorbian_spelling_dictionary-0.0.20060327.2-fx+tb+sm.xpi
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 2 Caolan McNamara 2008-10-06 09:03:27 UTC
New Package CVS Request
=======================
Package Name: hunspell-hsb
Short Description: Upper Sorbian hunspell dictionary
Owners: caolanm
Branches: 
InitialCC:

Comment 3 Huzaifa S. Sidhpurwala 2008-10-06 09:46:58 UTC
cvs done


Note You need to log in before you can comment on or make changes to this bug.