SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBD-Multi-0.14-1.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBD-Multi.spec Description: This software manages multiple database connections for failovers and also simple load balancing. It acts as a proxy between your code and your database connections, transparently choosing a connection for each query, based on your preferences and present availability of the DB server.
http://koji.fedoraproject.org/koji/taskinfo?taskID=862415
I wonder if (quoting from http://koji.fedoraproject.org/koji/getfile?taskID=862416&name=build.log ) is normal: t/pod-coverage......... skipped: Pod not available for individual methods in DBD::Multi, use DBI instead.
That is a rather weird test to have in there, as the author has everything skipped: plan skip_all => 'Pod not available for individual methods in DBD::Multi, use DBI instead.'; So, I'm not sure it's normal, but it's certainly expected in this instance :)
- rpmlint is silent - package name is ok - the spec file name match the base package - the package meet the packaging guidelines - license is ok (although it can be stated more directly than short notice in Makefile.PL, can you contact upstream to state it more clearly in README or in POD documentation?) - License field in the package spec file must match the actual license. - spec file is written in American English. - The spec file for the package is legible. - source has the same md5sum as upstream (d24534cdbbc274338b662d96809430d6) - build successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=879575 - all build dependencies are listed in BuildRequires - A package own all directories that it creates. - A package do not contain any duplicate files in the %files listing. - Permissions on files are set properly. - package have a %clean section - package consistently use macros - The package contain code, or permissable content - files in %doc, it do not affect the runtime of the application - At the beginning of %install, each package run rm -rf %{buildroot} - All filenames in rpm packages are valid UTF-8. You should have in Requires perl(DBI) since Multi.pm call several times function DBI->foo or DBI::foo. But since the upstream do not have "use DBI" in code, I'll not take it as blocker. But I encourage you to fill it as bug to upstream. APPROVED
New Package CVS Request ======================= Package Name: perl-DBD-Multi Short Description: DB Proxy with failover and load balancing Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done
The DBI dependency is sorta roundabout -- DBD::Multi uses DBD::File, which in turn uses DBI (and is actually included in the DBI distribution). You're right that it would be nice to have an explicit dep, however :) Imported and building in devel. Thanks for the review! :-)