Red Hat Bugzilla – Bug 465928
Review Request: fbterm - a fast terminal emulator for linux with frame buffer device
Last modified: 2008-10-29 23:15:35 EDT
Spec URL: http://dchen.fedorapeople.org/files/rpms/fbterm.spec
SRPM URL: http://dchen.fedorapeople.org/files/rpms/fbterm-1.1-0.fc9.src.rpm
FbTerm is a fast terminal emulator for linux with frame buffer device.
- mostly as fast as terminal of linux kernel while accelerated scrolling
is enabled on framebuffer device
- select font with fontconfig and draw text with freetype2, same as
Qt/Gtk+ based GUI apps
- dynamicly create/destroy up to 10 windows initially running default
- record scrollback history for every window
- auto-detect text encoding with current locale, support double width
scripts like Chinese, Japanese etc
- switch between configurable additional text encodings with hot keys
on the fly
- copy/past selected text between windows with mouse when gpm server
rpmlint gave me
fbterm.i386: E: setuid-binary /usr/bin/fbterm root 04755
The file is setuid, this may be dangerous, especially if this file is setuid
fbterm.i386: E: non-standard-executable-perm /usr/bin/fbterm 04755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.
also, I don't see any need of following in SPEC
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
package failed to build on dist-f10 see
Can you update SRPM with above fixes?
Still not buildable with F-10, other issues are fixed.
Thanks to David Woodhouse for his help on IRC to fix F10 build issue. Actually problem is fbterm.cpp is using kernel header file
which should be
Created attachment 320522 [details]
Patch to fix headers
Thanks for the patch, it works.
The revised SPEC and SRPM:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=883692
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI App.
1) I see following in build.log
configure: WARNING: gpm.h dosn't exist! gpm mouse support will be disabled!
If you want you can add that support.
==> you can do that by adding BR:gpm-devel in SPEC
2) drop line in %build
CFLAGS="-D__GNUC__" ; export CFLAGS
3) defattr usage should be
4) Drop unnecessary file INSTALL from %docs
Make sure to fix above issues before committing to CVS.
Thanks so much for helping me to fix the issues.
The revise spec and srpm which address your latest comments are at:
New Package CVS Request
Package Name: fbterm
Short Description: a fast terminal emulator for linux with frame buffer device
Branches: F-9 F-10 EL-5
can we close this if package is built for all requested branches?