Bug 466660 - Review Request: sympy - A Python library for symbolic mathematics
Summary: Review Request: sympy - A Python library for symbolic mathematics
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-12 11:17 UTC by Conrad Meyer
Modified: 2008-11-07 21:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-15 23:28:31 UTC
Type: ---
Embargoed:
gwync: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Conrad Meyer 2008-10-12 11:17:41 UTC
Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/sympy.spec
SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/sympy-0.6.2-1.fc9.src.rpm
Description:
SymPy aims to become a full-featured computer algebra system (CAS)
while keeping the code as simple as possible in order to be
comprehensible and easily extensible. SymPy is written entirely in
Python and does not require any external libraries.

Comment 1 Conrad Meyer 2008-10-12 19:04:10 UTC
Builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=875246

Comment 2 Gwyn Ciesla 2008-10-13 15:24:23 UTC
Starting full review. . . .

Comment 3 Gwyn Ciesla 2008-10-13 16:11:11 UTC
rpmlint on SRPM is clean

rpmlint on RPMs:

sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/utilities/compilef.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/solvers/numeric.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/elliptic.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

sympy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/sympy/mpmath/tests/test_elliptic.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Since these aren't meant to be executable, it would be good to patch out the shebangs and send the patch upstream.

Otherwise, full review looks great.

Comment 5 Gwyn Ciesla 2008-10-14 13:36:22 UTC
Alright, there we go.  Looks good.

APPROVED.

Comment 6 Conrad Meyer 2008-10-14 15:28:37 UTC
New Package CVS Request
=======================
Package Name: sympy
Short Description: A Python library for symbolic mathematics
Owners: konradm
Branches: F-9 F-10
InitialCC:

Comment 7 Huzaifa S. Sidhpurwala 2008-10-15 05:33:14 UTC
cvs done

Comment 8 Conrad Meyer 2008-10-15 23:28:31 UTC
Built in rawhide. Thanks for the review!

Comment 9 Susi Lehtola 2008-11-06 11:46:04 UTC
Please add also branch for EPEL (at least 5), and build documentation into a -doc package.

HTML documentation builds fine, LaTeX doesn't seem to work.

Comment 10 Conrad Meyer 2008-11-06 16:57:13 UTC
Package Change Request
======================
Package Name: sympy
New Branches: EL-5
Owners: konradm

Comment 11 Conrad Meyer 2008-11-07 00:18:35 UTC
Wait, no, I don't want to maintain this for EPEL. You can take it if you like.

Comment 12 Susi Lehtola 2008-11-07 06:45:53 UTC
Fine.

Package Change Request
======================
Package Name: sympy
New Branches: EL-5
Owners: jussilehtola

Comment 13 Kevin Fenzi 2008-11-07 21:38:46 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.