Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/iml.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/iml-1.0.2-1.fc9.src.rpm Description: IML package provides efficient routines to solve nonsingular systems of linear equations, certified solve any shape systems of linear equations, and perform mod p matrix operations, such as computing row-echelon form, determinant, rank profile, inverse of a mod p matrix.
I don't think it makes sense to package a main iml package with only doc, just put everything in -devel. doc/liblink should be shipped. I don't really like the name, it is very short and prone to conflicts, see http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace I doubt that upstream is willing to reconsider th ename, though. I propose adding %check make check You could ship ChangeLog if you feel like it. rpmlint gives: iml.i386: E: no-binary iml-devel.i386: W: no-documentation iml-debuginfo.i386: E: empty-debuginfo-package The 2 first should be fixed by removing main package. You can fix the 3rd if you want to (it is mandated by the guidelines, but I disagree, and I will approve even with this issue).
http://konradm.fedorapeople.org/fedora/SPECS/iml.spec http://konradm.fedorapeople.org/fedora/SRPMS/iml-1.0.2-2.fc9.src.rpm
* rpmlint gives: iml-debuginfo.i386: E: empty-debuginfo-package which is against the guidelines, but I don't think this is important (and besides I think it is a bug in rpm, not to have debug info extracted from static libs). * follow relevant guidelines * free software, no license included because upstream doesn't ship a license consistent with the code * match upstream: 03a2e361bf9574ae8d32c19a392eeb66 iml-1.0.2.tar.gz * all static correctly packaged library * %files section right One suggestion, use make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' too tentatively keep header file timestamps. Also you should contact upstream to ask them to change the COPYING file. (well in fact the license isn't that clear when repl/ is used, but it isn't th ecase in fedora, and in any case they should clarify the license). APPROVED
Thanks for the suggestions, I really value them. New Package CVS Request ======================= Package Name: iml Short Description: Finds solutions to systems of linear equations over integers Owners: konradm Branches: F-10 F-9 InitialCC:
cvs done.
Built in rawhide [0], closing. [0]: http://koji.fedoraproject.org/koji/taskinfo?taskID=889730