Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.0-1.fc9.src.rpm Description: CVXOPT is a free software package for convex optimization based on the Python programming language. Its main purpose is to make the development of software for convex optimization applications straightforward by building on Python's extensive standard library and on the strengths of Python as a high-level programming language.
http://koji.fedoraproject.org/koji/taskinfo?taskID=876733 <-- Builds in koji.
I'll review this package. But first, can you update to the latest version?
Sure.
New URLs: http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.1-1.fc9.src.rpm
It seems like you forgot to upload the SRPM.
Hrm, my uploader script is slightly broken -- should be up now.
OK, there are a few things that need attention. Otherwise everything seems good. * There is a bunch of compiled C code in the package (under src/C/SuiteSparse). Some are released under GPLv2+, others under LGPLv2+. So I think the correct license tag should be "GPLv3+ and LGPLv2+". Also there are lots of doc files inside subdirectories of this directory. They need to be packaged. * There is also a doc directory right on the root of the tarball that contains a Makefile. I think that these docs should be built and included in the package. You'll probably need to BR some latex package(s) for this. * rpmlint gives a huge amount of warnings and errors. There are basically two types of these: W: doc-file-dependency W: spurious-executable-perm There are two ways to fix these. Either, change the permissions of these files to 644, OR (the way I'd prefer) put the examples directory inside %{_datadir}/%{name}. ! This package softly depends on pymosek which is proprietary software. But since it is not a direct requirement, this can't be a blocker. * Python eggs are handled a little differently for non-setuptools packages. In order to create the python egg the proper way, please follow the example in this guideline: http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages
(In reply to comment #7) > * Also there are lots of doc files > inside subdirectories of this directory. They need to be packaged. Hm, which subdirectories? > * There is also a doc directory right on the root of the tarball that contains > a Makefile. I think that these docs should be built and included in the > package. You'll probably need to BR some latex package(s) for this. OK. > * rpmlint gives a huge amount of warnings and errors. There are basically two > types of these: > W: doc-file-dependency > W: spurious-executable-perm > There are two ways to fix these. Either, change the permissions of these files > to 644, OR (the way I'd prefer) put the examples directory inside > %{_datadir}/%{name}. OK. > * Python eggs are handled a little differently for non-setuptools packages. In > order to create the python egg the proper way, please follow the example in > this guideline: > > http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages Oh, oops. I've done this correctly before, it just slipped my mind. Thanks for pointing this out. New URLs to address the criticisms mentioned in the previous comment (I'm still unsure what you mean by commented quoted first above): http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.1-2.fc9.src.rpm
I've hacked out the included copy of the system library suitesparse. New URLs: http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.1-3.fc9.src.rpm
Thanks. But since there's a binary incompatibility between the versions of suitesparse, we need to block the suitesparse update request bug. * The directory /usr/share/doc/python-cvxopt-1.1/html is empty. Those latex files are not built properly. * You need to put an explicit Requires on python-matplotlib since some of the examples will need this library.
(In reply to comment #10) > Thanks. But since there's a binary incompatibility between the versions of > suitesparse, we need to block the suitesparse update request bug. Right. Thanks for filing that bug on suitesparse and adding it as blocking this bug. > * The directory /usr/share/doc/python-cvxopt-1.1/html is empty. Those latex > files are not built properly. I'm fixing this now by forcing the rebuild (make -B). > * You need to put an explicit Requires on python-matplotlib since some of the > examples will need this library. I created an examples subpackage and had the -examples package require python-matplotlib. New URLs: http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.1-4.fc9.src.rpm
Everything seems good. Now we'll have to wait for suitesparse.
Still have to wait :).
python-cvxopt works after the latest atlas & suitesparse builds in rawhide. There is one little missing thing I noticed: * You should BR: python-setuptools-devel otherwise the package will not build on mock. Please do this before you commit. Until the correctly linked versions of atlas and suitesparse are pushed to the F-9/F-10 branches, you will need to reside python-cvxopt in rawhide only. ------------------------------------------------ This package (python-cvxopt) is APPROVED by oget ------------------------------------------------
New Package CVS Request ======================= Package Name: python-cvxopt Short Description: A Python Package for Convex Optimization Owners: konradm Branches: F-10 F-9 InitialCC:
cvs done.
Built in rawhide, closing.