Red Hat Bugzilla – Bug 466742
Review Request: hunspell-te - Telugu hunspell dictionaries
Last modified: 2008-10-15 01:50:46 EDT
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-te.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-te-0.20050929-1.fc9.src.rpm Description: Telugu hunspell dictionaries
The other way to generate hunspell dictionary from actual aspell source is as prezip-bin -d <te.cwl >telugu.words wordlist2hunspell telugu.words te_IN Thus, you will be using Source tag and actual source tarball in SRPM. What do you say? Do you still want to use BR:aspell-te way or use of actual source?
Created attachment 320191 [details] Modified SPEC that will use upstream Source
Maybe we should. Might be a little bit too overly-cunning to fiddle. The above way is pretty much what I do for a future proposed hunspell-mt.
(In reply to comment #3) > Maybe we should. Might be a little bit too overly-cunning to fiddle. The above > way is pretty much what I do for a future proposed hunspell-mt. OK. Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=877432 + rpmlint is silent for SRPM and for RPM. + source files not verified as dependent aspell-te package is already verified with upstream in its own review. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions:- 1) Can you preserve timestamp of documentation files by using following in SPEC cp -p %{_docdir}/aspell-te*/* . APPROVED.
Do you want to be the -te maintainer ? So as to keep the same maintainer for all the Indic ones ? I don't mind either way, just giving you that option.
thanks for asking. Definitely I like to co-maintainer/maintainer for this package.
New Package CVS Request ======================= Package Name: hunspell-te Short Description: Telugu hunspell dictionary Owners: pnemade Branches: InitialCC:
cvs done
built on koji. thanks all.