Bug 466994 - Publican doesn't allow underscores or numbers in entity names
Summary: Publican doesn't allow underscores or numbers in entity names
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 1.6
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeff Fearn 🐞
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-15 00:07 UTC by Jared Smith
Modified: 2010-11-24 04:17 UTC (History)
3 users (show)

Fixed In Version: 0.38
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-15 00:59:08 UTC
Embargoed:


Attachments (Terms of Use)

Description Jared Smith 2008-10-15 00:07:09 UTC
Description of problem:

Publican is overly strict on the name of XML entites.  It should allow all valid entity names.

Version-Release number of selected component (if applicable):

0.37

How reproducible:

Easily

Steps to Reproduce:
1. create_book --name=blah
2. add '<!ENTITY TEST_ENTITY "To be filled out later">' to en-US/blah.ent
3. add '&TEST_ENTITY;' to one of the .xml files
4. Generate HTML and PDF version of the book
  
Actual results:
You'll see the literal text '&TEST_ENTITY;' in the document

Expected results:

The entity should be replaced by its definition.  In other words, you should see the text "To be filled out later" in the document.

Additional info:
Discussed with jfearn on IRC, and he confirms that it's a bug in the Perl code that munges the XML.

Comment 1 Jeff Fearn 🐞 2008-10-15 00:59:08 UTC
Changed regex in xmlClean to also match underscores and numerals.

Comment 2 Fedora Update System 2008-10-16 22:44:01 UTC
publican-0.38-0.fc9,perl-XML-TreeBuilder-3.09-11.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/publican-0.38-0.fc9,perl-XML-TreeBuilder-3.09-11.fc9

Comment 3 Fedora Update System 2008-11-07 02:55:20 UTC
publican-0.38-0.fc9, perl-XML-TreeBuilder-3.09-11.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.