Red Hat Bugzilla – Bug 466997
Review Request: sl - Joke command for when you type 'sl' instead of 'ls'
Last modified: 2008-10-28 01:06:21 EDT
Spec URL: http://marcbradshaw.co.uk/packages/review/sl/sl.spec
SRPM URL: http://marcbradshaw.co.uk/packages/review/sl/sl-3.03-3.fc9.src.rpm
The sl (Steam Locomotive) command is a joke which displays a train on your
terminal when you accidentally type 'sl' instead of 'ls'
The sl package has been part of the dribble repo for some time, during review for the rpmfusion repo the licence issues were resolved and the package should now be fine for inclusion in fedora.
1 - http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2008-October/001599.html
I am happy to see this package on Fedora, because this is well-known to
Japanese Linux users ;)
The mail transcript should be directly in the package as asource, so
would work, with cp and adding to %doc.
I suggest removing the /bin/ and let the commands be searched on the path.
You should use cp -p and install -p (for the manpage) to keep timestamps.
Also I suggest doing something along:
iconv -f iso-2022-jp README -t utf8 > README.conv README.conv && \
touch -c -r README && \
mv README.conv README
Also the -f of rm is not needed, it is always the default in rpm.
Forgot to say that there is a dot missing at the end of %description.
I assume you mean mv -f rather than rm -f and have incorporated the suggestions into a new revision.
The timestamp of the source archive is not kept:
-rw-rw-r-- 1 dumas dumas 20480 juil. 22 1999 sl.tar
-rw-rw-r-- 1 dumas dumas 20480 févr. 13 2008 ../SOURCES/sl.tar
Otherwise seems ok to me.
Forgot one thing. In general I think that it is pretty bad to use
a two letter command, since the number of two letter command names
is scarce and they should be used wisely. However in that case I think
that the name is not really taken since sl could just go if something
serious wants the command name.
Some notes for -4:
- Please write explicitly from which you borrowed the license
text in the spec file (and also in sl.COPYRIGHT) as comments.
Perhaps it is from:
- We now recommend %defattr(-,root,root,-)
- Files under %_mandir are automatically marked as %doc.
One more thing:
* %dist tag
- Please remove %dist tag from %changelog entry.
apologies, should be able to get something up this coming weekend.
Sorry for the delay, been a busy week. The changes have been made to new SRPM located at...
looks good to me, final word is for Mamoru.
Oops, one note:
* Man file
- Please move man.1 to %_mandir/ja/man1.
(Maybe %lang(ja) is preferable).
( This package (sl) is APPROVED by mtasaka )
++ +------ ____ ____________________
|| |+-+ | | \@@@@@@@@@@@ | ___ ___ Help!__ |
/---------|(O) | | \@@@@@@@@@@@@@_ | (O) |_| \O/ |_| |
+ ======== +-+ | | | |__________________|
_|--/~\------/~\-+ |__________________| |__________________|
//// \O========O/ (O) (O) (O) (O)
New Package CVS Request
Package Name: sl
Short Description: Joke command for when you type 'sl' instead of 'ls'
Branches: F-8 F-9 EL-4 EL-5
thanks all, imported and building.