Red Hat Bugzilla – Bug 467341
buildinstall calls createrepo even when not needed
Last modified: 2009-01-20 16:37:41 EST
/usr/lib/anaconda-runtime/buildinstall There's a call to createrepo, but this call is only needed when the script is called with --pkgorder. Testing for this and skipping the call when --pkgorder isn't used will cut down the runtime by a very significant percentage (50% or more).
The change seems trivial but I am not sure (because I don't know where and how buildinstall is used) about the assumption that createrepo is needed to be called only when --pkgorder is used. Can you just assure me that it is so? (Dan Mach thinks that wrt to the usage of buildinstall, not running createrepo shouldn't break anything.)
I'm not a buildinstall expert, but my comment about createrepo was based on a scan of the sources, so I am fairly confident in it. It's also something that we can test easily once we have a build with the change.
Modified, will be included in 11.1.2.150.
Dennis, can you confirm that everything is working as expected and the changes reduced compose time? Thanks.
Yes, it appears that the changes worked. Below are the times (in seconds) that the buildinstall runs took before and after the change. Thanks! # anaconda-11.1.2.145-1 $ ./bin/profile distill-RHEL5.3-Server-20081020.1.log | grep buildinstall create_buildinstall (arch=i386): 1748 create_buildinstall (arch=x86_64): 2484 create_buildinstall (arch=s390x): 2663 create_buildinstall (arch=ppc): 3119 create_buildinstall (arch=ia64): 3959 # anaconda-11.1.2.154-1 $ ./bin/profile distill-RHEL5.3-Server-20081105.1.log | grep buildinstall create_buildinstall (arch=x86_64): 493 create_buildinstall (arch=ppc): 717 create_buildinstall (arch=i386): 724 create_buildinstall (arch=s390x): 970 create_buildinstall (arch=ia64): 971
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-0164.html