Red Hat Bugzilla – Bug 467507
Review Request: hiran-rufscript-fonts - Rufscripts is a decorative handwriting based font
Last modified: 2013-03-13 01:44:03 EDT
Spec URL: http://sundaram.fedorapeople.org/packages/rufscript-fonts.spec
SRPM URL: http://sundaram.fedorapeople.org/packages/rufscript-fonts-0.1-1.fc10.src.rpm
Rufscripts is a handwriting based font suitable for comic scripts and
small labels. It is created using completely free and open source tools.
Other than a warning about missing documentation (we don't have any), rpmlint is clean but do check the conf file and other details for the review.
Automated result from review-o-matic
rufscript-fonts.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
1. Since Minto Joseph and you are both packaging Hiran's fonts, you should get together and interact with Hiran collectively (see bug #457709).
2. It's not a good idea to keep the versioning in the TTF filename, some apps refer fonts by filename and will get cross with you if it changes every version
3. You should discuss with Minto if you want to adopt a common prefix for your font packages names (for example hiranv-rufscript-fonts and perizia-rufscript-fonts). We've more or less started to do it for big foundries (gfs, sil) and some individual font authors (thibault), it's probably better to generalise the convention to have consistent naming
(please subscribe to the fonts SIG list if you haven't done so yet to get informed of packaging convention evolutions)
4. you can drop the -f in the fc-cache invocation for releases ≥ Fedora 9
5. Some people want all Fedora-added source files in a package to be prefixed with the package name. You don't follow this convention for your fontconfig file. Please take inspiration from the general packaging guidelines or Minto's package to fix it.
→ bug #457709
6. 69 is a bit low, for a latin font like rufscript something between 62 and 64 would be fine
7. Please have upstream publish rufscript in a proper versioned archive with a detached license file you can add in %doc
8. Please reformat your xml files with xmllint --format before submission so they are nicely indented
9. I would have declared rufscript as a cursive font, not a sans-serif one
10. Please add a "Generic name" rule in addition to the "Registering a font in default families" rule
This rule is used by fontconfig to complete your font with glyphs from other fonts when it encounters a codepoint your font is missing
This rule is used by fontconfig to identify what fonts to use when an application requests a "cursive" font.
11. When you've written fontconfig rules you're happy with it's always a good idea to send them upstream to be included in the font next releases (in the versionned archive you're supposed to request)
Despite the long todo list your spec is in good shape overall and it should not take much to get it in a state that can be approved.
[This is a simplified version of the message sent to every package maintainer that ships TTF/OTF/Type1 fonts in Fedora.]
Our font packaging guidelines have now changed. New font package submissions must now be adapted to the new templates available in the fontpackages-devel
It is preferred to create a font package or subpackage per font family, though
it is not currently a hard guidelines requirement.
has been submitted for FPC and FESCO approval today.
The new templates should make the creation of font packages easy and safe.
The following packages have already been converted by their packager in fedora-devel and can serve as examples:
The new spec templates have been designed to be easy to update to from the previous guidelines, and to remove complexity from font packages. To help new package creation the fontpackages-devel package has been made available in Fedora 9 and 10.
If you have any remaining questions about the new guidelines please ask them
fedora-fonts-list at redhat.com
Hiran is promising a new release and an new website in October.
Meanwhile on the packaging side since he created multiple fonts it would be nice to use a common prefix on the packages (similar to the apanov- prefix we use in packaging Andrey Panov's fonts) to mark they have the same origin (as required by guidelines)
I've created a new .spec and SRPM for this font, as I was talking with Mairin Duffy today and she showed me this font.
I made a couple of assumptions on this font -- please correct me if these assumptions are wrong:
1) The version in the filename is "010", but I couldn't tell if this means "0.1" or "0.10" or "0.100". I used fontforge to look at the font metadata, and it said the version was "0.100", so I'm using that for the version number.
2) Comment 5 mentioned a font packaging prefix -- I've used the prefix of "hiran" in this package.
Is Rahul with you taking over this package? (The passage of time suggests yes, but you never know.)
1. The spec name must be the same as the package name.
2. The license in the source file is GPLv3+ with exceptions
3. The SFD contains the line "Version: 0.1.0" and this is consistent with Hiran's other font under review at the moment, Perizia, but version control of fonts is notoriously bad so 0.100, pulled from the name table, is OK.
4. The fontconfig is very wrong, as you've said that the font "Sans" is the same as the font "Rufscript". Please use the basic fontconfig template and declare this as a cursive font.
5. From Nicolas's previous comment #2, points 6 and 7 still apply.
Other than those, this is a simple package, and almost ready for approval.
Jared, are you still interested in this?
Yes, I'll fix it up over the next day or so.
Ping? Any progress here? Or we can close this review?
Stalled Review. Closing per:
If you ever want to continue with this review, please reopen or
submit new review.