Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 468034

Summary: RHEL 5.3: minor virtio_net_fixes
Product: Red Hat Enterprise Linux 5 Reporter: Mark McLoughlin <markmc>
Component: kernelAssignee: Mark McLoughlin <markmc>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3CC: kernel-mgr, mgahagan, ovirt-maint, syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-20 20:16:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
1
none
2
none
3
none
4 none

Description Mark McLoughlin 2008-10-22 14:27:59 UTC
Since the initial backport of virtio_net for RHEL 5.3, we have identified a number of fixes required:

 1) Fix leaked netdev->refcnt - it can often be impossible to unload
    the virtio_net driver with rmmod because of a device refcount
    leak. The bug does not exist upstream because it is in code added
    as part of the backport.

    This is quite a serious bug.

 2) Support ethtool offload queries - a simple and safe ethtool change
    needed because of differences between 2.6.18 and upstream.

    This is useful to people testing different GSO settings.

 3) Make use of napi_weight module param - the backport caused the
    napi_weight module param to be ignored.

    This is a clear bug - minor but the fix is very safe.

 4) Recycle some more rx buffer pages - trivial, safe optimization
    which will be in 2.6.28.

    This is a simple performance fix.

Each of these fixes are relatively minor and have tested all these patches quite extensively as part of our general testing efforts around RHEL5 virtio drivers.

Comment 1 Mark McLoughlin 2008-10-22 14:30:48 UTC
Created attachment 321158 [details]
1

Comment 2 Mark McLoughlin 2008-10-22 14:31:15 UTC
Created attachment 321159 [details]
2

Comment 3 Mark McLoughlin 2008-10-22 14:31:33 UTC
Created attachment 321160 [details]
3

Comment 4 Mark McLoughlin 2008-10-22 14:31:52 UTC
Created attachment 321161 [details]
4

Comment 6 RHEL Program Management 2008-10-22 16:37:40 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 7 Don Zickus 2008-11-04 16:51:10 UTC
in kernel-2.6.18-122.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 10 errata-xmlrpc 2009-01-20 20:16:04 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html