Description of problem: When checking a directory tree in autofs_tree_busy() we can incorrectly decide that the tree isn't busy. This happens for the case of an active offset mount as autofs4_follow_mount() follows past the active offset mount, which has an open file handle used for expires, causing the file handle not to count toward the busyness check. Version-Release number of selected component (if applicable): Current RHEL-5 beta kernel. How reproducible: Occassionally. Steps to Reproduce: I noticed this while testing using the autofs connectathon test suite. Actual results: The symptom is messages in the log of the form: cache_delete_offset_list: active offset mount key /automount/test1/g9j/s1 Expected results: No incorrect messages in the log. Additional info: The message results from the incorrect expire request returning a failure to the kernel module when another process concurrently performing a lookup waits for that expire and then issues a mount request for a multi-mount with an active mount(s). While the daemon catches this case and issues the message above it shouldn't happen.
Created attachment 321292 [details] Patch to cleanup autofs mount type usage This patch is one of two patches to cleanup the autofs mount type usage. The later patch isn't required by the following bug fix patch and is planned for submission to RHEL-5.4. The bug fix patch however does require that the autofs mount type always be set explicitly. The current autofs4 code doesn't do this, setting the default type to 0 instead of AUTOFS_TYPE_INDIRECT, which was previously not a problem.
Created attachment 321294 [details] Patch to correct offset mount expire check This patch corrects the incorrect expire check and eliminates the annoying log messages.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
in kernel-2.6.18-122.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-0225.html