Bug 468539 - Review Request: sugar-jukebox - Media player activity for Sugar
Summary: Review Request: sugar-jukebox - Media player activity for Sugar
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Bryan Kearney
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: FedoraOLPCDelta
TreeView+ depends on / blocked
Reported: 2008-10-25 18:29 UTC by Sebastian Dziallas
Modified: 2010-06-11 04:40 UTC (History)
7 users (show)

Clone Of:
Last Closed: 2008-12-03 01:23:41 UTC
bkearney: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

External Trackers
Tracker ID Priority Status Summary Last Updated
OLPC 9013 None None None Never

Description Sebastian Dziallas 2008-10-25 18:29:30 UTC
Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-3-1.fc10.src.rpm
Description: The jukebox activity is an audio/video player that will play different kind of files bases on the installed gstreamer plugins.

Comment 1 Simon Schampijer 2008-10-29 11:58:18 UTC
I pinged the maintainer for cleaning the permission issues you worked around in the SPEC.

Comment 2 Simon Schampijer 2008-11-12 19:07:25 UTC
new sources have been released http://kushaldas.in/tmp/Jukebox-4.tar.bz2

Comment 3 kushaldas@gmail.com 2008-11-14 09:24:40 UTC
Please use the latest source http://kushaldas.in/tmp/Jukebox-5.tar.bz2

Comment 4 Sebastian Dziallas 2008-11-14 13:28:54 UTC
I updated the files for release 5...

Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-1.fc10.src.rpm

Comment 5 Fabian Affolter 2008-11-19 08:43:25 UTC
In another review request Marco suggested to check if 'mkdir -p %{buildroot}%{sugaractivitydir}' in the %build section is actually necessary because setup.py takes care of it. 

If you are using 'http://kushaldas.in/tmp/Jukebox-%{version}.tar.bz2' instead of 'http://kushaldas.in/tmp/Jukebox-5.tar.bz2' in Source0 you haven't to take care about this line in the future.

Comment 6 Sebastian Dziallas 2008-11-19 14:24:20 UTC
Thanks for the comments! I uploaded a modified version:

Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-2.fc10.src.rpm

Comment 7 Bryan Kearney 2008-11-21 13:31:47 UTC
  OK - Package name
  OK - License info is accurate
  OK - License tag is correct and licenses are approved
  OK - License files are installed as %doc
  OK - Specfile name
  OK - Specfile is legible
  OK - No prebuilt binaries included
  OK - BuildRoot value (one of the recommended values)
  OK - PreReq not used
  XX - Source md5sum matches upstream
	These do not match, and upstream is "hidden". Please
	change to a checkout from source repo.

  OK - No hardcoded pathnames
  OK - Package owns all the files it installs
  OK - 'Requires' create needed unowned directories
  OK - Package builds successfully on i386 and x86_64 (mock)
  OK - BuildRequires sufficient
  OK - File permissions set properly
  OK - Macro usage is consistent
  OK - rpmlint is silent
	Warnings are OK

I have not installed it onto a blank sugar install yet, but have you verified all the imports are in the Requires?
Please resolve the source code and I will re-review.

Comment 8 Bryan Kearney 2008-11-21 15:22:05 UTC
I was able to install it, and "run" it. But.. it did not do anything. Is there a way for me to verify it is working?

Comment 9 kushaldas@gmail.com 2008-11-24 09:49:41 UTC
Download any song using browse and then play it from journal. Btw, I just found a bug which prevents it playing songs/videos with filename containing spaces or @ signs :(

Comment 10 Bryan Kearney 2008-11-24 14:37:21 UTC
Thanks.. seems to be ok. If the comment around the download is fixed I will approve.

-- bk

Comment 11 kushaldas@gmail.com 2008-11-24 17:48:54 UTC
Ah, Bryan I am not sure when I can do a new release :(
Can you approve it for now ? Sebastian can update it when I will make the new release.

Comment 12 Bryan Kearney 2008-11-24 17:56:26 UTC
Actually..if Sebastian changes it to a checkout script, then I would be good.

-- bk

Comment 13 Sebastian Dziallas 2008-11-24 18:36:04 UTC
Okey dokey... sorry for the late reply, but I was a bit busy during the weekend. The new version here now includes a checkout script.

Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-3.fc10.src.rpm

Comment 14 Bryan Kearney 2008-11-24 19:13:23 UTC

Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import
the package. Close this bug as RAWHIDE once it's been successfully
imported and built.

Comment 15 Sebastian Dziallas 2008-11-24 20:03:18 UTC
New Package CVS Request
Package Name: sugar-jukebox
Short Description: Media player activity for Sugar
Owners: sdz
Branches: F-9 F-10
InitialCC: kushal

Comment 16 Dennis Gilmore 2008-11-25 16:23:01 UTC
CVS Done

Comment 17 Fedora Update System 2008-11-25 18:08:07 UTC
sugar-jukebox-5-3.fc10 has been submitted as an update for Fedora 10.

Comment 18 Fedora Update System 2008-11-26 06:20:22 UTC
sugar-jukebox-5-3.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sugar-jukebox'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10338

Comment 19 Fedora Update System 2008-12-03 01:23:38 UTC
sugar-jukebox-5-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Peter Robinson 2010-06-10 21:10:49 UTC
Package Change Request
Package Name: sugar-jukebox
New Branches: EL-6
Owners: pbrobinson sdz

Comment 21 Kevin Fenzi 2010-06-11 04:40:24 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.