Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-3-1.fc10.src.rpm Description: The jukebox activity is an audio/video player that will play different kind of files bases on the installed gstreamer plugins.
I pinged the maintainer for cleaning the permission issues you worked around in the SPEC.
new sources have been released http://kushaldas.in/tmp/Jukebox-4.tar.bz2
Please use the latest source http://kushaldas.in/tmp/Jukebox-5.tar.bz2
I updated the files for release 5... Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-1.fc10.src.rpm
In another review request Marco suggested to check if 'mkdir -p %{buildroot}%{sugaractivitydir}' in the %build section is actually necessary because setup.py takes care of it. If you are using 'http://kushaldas.in/tmp/Jukebox-%{version}.tar.bz2' instead of 'http://kushaldas.in/tmp/Jukebox-5.tar.bz2' in Source0 you haven't to take care about this line in the future.
Thanks for the comments! I uploaded a modified version: Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-2.fc10.src.rpm
OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used XX - Source md5sum matches upstream These do not match, and upstream is "hidden". Please change to a checkout from source repo. OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent OK - rpmlint is silent Warnings are OK I have not installed it onto a blank sugar install yet, but have you verified all the imports are in the Requires? Please resolve the source code and I will re-review.
I was able to install it, and "run" it. But.. it did not do anything. Is there a way for me to verify it is working?
Download any song using browse and then play it from journal. Btw, I just found a bug which prevents it playing songs/videos with filename containing spaces or @ signs :(
Thanks.. seems to be ok. If the comment around the download is fixed I will approve. -- bk
Ah, Bryan I am not sure when I can do a new release :( Can you approve it for now ? Sebastian can update it when I will make the new release.
Actually..if Sebastian changes it to a checkout script, then I would be good. -- bk
Okey dokey... sorry for the late reply, but I was a bit busy during the weekend. The new version here now includes a checkout script. Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-jukebox-5-3.fc10.src.rpm
APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built.
New Package CVS Request ======================= Package Name: sugar-jukebox Short Description: Media player activity for Sugar Owners: sdz Branches: F-9 F-10 InitialCC: kushal
CVS Done
sugar-jukebox-5-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/sugar-jukebox-5-3.fc10
sugar-jukebox-5-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update sugar-jukebox'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10338
sugar-jukebox-5-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: sugar-jukebox New Branches: EL-6 Owners: pbrobinson sdz
cvs done.