Spec URL: http://8uxodw.bay.livefilestore.com/y1pAo4InJN4FWu1IzlQB6yUvQm7JvNpms4NZDXkABcx_RSFY6vEdJLKu-MDLuWF3o5yVEc1T6HKN477JS3gj1cq9w/basket.spec?download SRPM URL: http://8uxodw.bay.livefilestore.com/y1ppmMFYmBd4iz_vpMzmFNihbd6LSN58WKwgQUEy24pY9qrQsZtxUDts4i0MrQsxuljvbArhv0pTPU/basket-1.0.3.1-1.fc10.src.rpm?download Description: Taking care of your ideas. A note-taking application that makes it easy to write down ideas as you think, and quickly find them back later. Organizing your notes has never been so easy.
I had to make a couple changes so here are new URLs: Spec URL: http://8uxodw.bay.livefilestore.com/y1phVJHr_dSr1gMt0-rHuTVAAUTrX26o8YAnkwqvlxzL4LOLRUxKl5GDl8ohc8QJL15RsU9md2O_PPWC_7Hv5uNOg/basket.spec?download SRPM URL: http://8uxodw.bay.livefilestore.com/y1pShllREhh39cP2V-sNezg4d6KwykdOHLVDBpDfaDdJDNACluD0spLx3PSi7-UQiwHzprAM7W-fxo/basket-1.0.3.1-1.fc10.src.rpm?download Output of rpmlint: basket.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 5) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. ^^^ Ignoring this one because it's just complaining about my formatting. basket.i386: W: file-not-utf8 /usr/share/doc/basket-1.0.3.1/AUTHORS basket.i386: E: invalid-soname /usr/lib/libbasketcommon.so libbasketcommon.so 2 packages and 0 specfiles checked; 1 errors, 1 warnings. ^^^ Ignoring the first warning because the authors name has a é and a û in it. I'm not sure what to do about the second error. Is there even a way I can fix that or is it an upstream problem?
Basket is already in Fedora: https://admin.fedoraproject.org/pkgdb/packages/name/basket
(In reply to comment #2) > Basket is already in Fedora: > > https://admin.fedoraproject.org/pkgdb/packages/name/basket Sorry, I should have been more clear. I submitted this review in response to: https://bugzilla.redhat.com/show_bug.cgi?id=452994. The current package maintainer didn't have time to update to the new release and told me I could do it if I wanted. I'm also seeking sponsorship so I figured it would be good submit another package in additional to my original.
Note to others I'm in the process of sponsoring Christopher, also see review bug 467958. Christopher, Ah, ok so this is a Re-Review, in the light of sponsoring you and in the light of the issues you've mentioned I think that is a good idea. It would have been good to mention that with the initial review submission though. So I'll assign this one to me (as your potential sponsor) and change the component to the existing basket as to not confuse all the automated review scripts and searches.
One more note for Christopher, I'm currently rather busy with things to fix before the final F-10 freeze (which is tonight) after that I'll make some time and review both this one and barry, of both reviews go ok (which I assume they will) I'll sponsor you once both packages are in a state where I'm happy to approve them.
(In reply to comment #4) > Note to others I'm in the process of sponsoring Christopher, also see review > bug 467958. > > Christopher, > > Ah, ok so this is a Re-Review, in the light of sponsoring you and in the light > of the issues you've mentioned I think that is a good idea. It would have been > good to mention that with the initial review submission though. Yes. :-) I would not have closed it if I knew the reasons for the re-review. A small note at begin it is enough. > So I'll assign this one to me (as your potential sponsor) and change the > component to the existing basket as to not confuse all the automated review > scripts and searches. Now, if I may add a note about the description: I don't like the second sentence in description: "Organizing your notes has never been so easy." I think it adds nothing useful to the description, even if I use just basket to take notes on computer. I understand that the description comes mostly from the package documentation and webpage but as packager we should strive to make the description mostly objective. This is not a blocker (if it were I would have to review all my packages descriptions before ;-) ) but it is something for you to consider (a nitpick).
Thanks Hans, and yes, I should have mentioned the re-review in my first comment but didn't think to. Sorry to throw you off as well José. José -- I agree with you about the description. What do you think about: "A multi-purpose note-taking application that makes it easy to write down ideas as you think, and quickly find them later. You can collect, import or share any data, tag your notes and secure it some or all of it with passwords and/or encryption."
I like the new formulation. :-)
(In reply to comment #1) > I had to make a couple changes so here are new URLs: > > Spec URL: > http://8uxodw.bay.livefilestore.com/y1phVJHr_dSr1gMt0-rHuTVAAUTrX26o8YAnkwqvlxzL4LOLRUxKl5GDl8ohc8QJL15RsU9md2O_PPWC_7Hv5uNOg/basket.spec?download > > SRPM URL: > http://8uxodw.bay.livefilestore.com/y1pShllREhh39cP2V-sNezg4d6KwykdOHLVDBpDfaDdJDNACluD0spLx3PSi7-UQiwHzprAM7W-fxo/basket-1.0.3.1-1.fc10.src.rpm?download > > Output of rpmlint: > > basket.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 5) > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > ^^^ Ignoring this one because it's just complaining about my formatting. > I know it may seem a bit pedantic, but this is a MUST FIX item, iow not something to be ignored. Mixing spaces and tabs is bad. So choose one and stick to it, note that the Fedora standard more or less is to use spaces, but tabs are allowed too if you prefer as long as you are consistent. > basket.i386: W: file-not-utf8 /usr/share/doc/basket-1.0.3.1/AUTHORS > ^^^ Ignoring the first warning because the authors name has a é and a û in it. This is another MUST FIX item, the trick is to change the encoding in %setup using iconv, so in this case you should add the following lines under %setup: iconv -f ISO_8859-1 -t UTF-8 AUTHORS > AUTHORS.tmp touch -r AUTHORS AUTHORS.tmp mv AUTHORS.tmp AUTHORS > basket.i386: E: invalid-soname /usr/lib/libbasketcommon.so libbasketcommon.so > 2 packages and 0 specfiles checked; 1 errors, 1 warnings. > I'm not sure what to do about the second error. Is there even a way I can fix > that or is it an upstream problem? With new packages we normally fix issues like this with Fedora specific patches, but given that this package is already in Fedora, I think we can leave this as is for now. You should file a bug upstream though, asking them to change this into a properly versioned .so file with a proper soname. I've done a review of this package, which besides the things mentioned above also has found the following issues: MUST FIX -------- * This line in the 2 post script is wrong: -p /sbin/ldconfig That should be just: /sbin/ldconfig SHOULD FIX ---------- * Update the description as discussed in previous comments
[Chris@localhost SPECS]$ rpmlint basket.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [Chris@localhost SPECS]$ rpmlint ../RPMS/i386/basket-* basket.i386: E: invalid-soname /usr/lib/libbasketcommon.so libbasketcommon.so 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Sorry for not responding to this sooner. I don't remember seeing an email about you making a comment. Anyway, I've fixed the problems from your last comment and created a bug upstream in regards to the so names. I also made a couple other changes: * added a Requires: hicolor-icon-theme * fixed some directory ownership issues in the main package -- I went back to what the previous maintainer was using in the old spec file * added %post and %postun in the kontact package SRPM: http://8uxodw.bay.livefilestore.com/y1pN1smuHPWD_G_o-6GvqfMrFFWKQ_QCWQvrjo2nLWZCgdW97SAKm-VMF5KDYPNnvYI2flfsP6jt1nxvVzO3DcpVQ/basket-1.0.3.1-2.fc10.src.rpm?download SPEC: http://8uxodw.bay.livefilestore.com/y1pN1smuHPWD_Gx1f3-jFUhPfCs53TbOfptJ9VJZ6DekO1Sh1cqKww2uVn2DJLc_4U6eZ1qKtNZ6ZknoH1Qu-6FZA/basket.spec?download
(In reply to comment #10) > * added %post and %postun in the kontact package > Erm, that is not necessary, only packages which install files directly under %{_libdir} need to have ldconfig running post scripts, if they drop files in a subdir of %{_libdir}, those files are plugins, not libraries and there is no reason to run ldconfig, so please remove the %post[un] scripts from the kontakt sub-package other then that it looks ok. So once you are sponsored (see barry review), you can ask the current basket maintainer to give you the necessary rights to co-maintain and submit this new version.
basket-1.0.3.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/basket-1.0.3.1-2.fc10
basket-1.0.3.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/basket-1.0.3.1-2.fc9
basket-1.0.3.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
basket-1.0.3.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.