Red Hat Bugzilla – Bug 469023
Review Request: perl-Class-Adapter - Perl implementation of the "Adapter" Design Pattern
Last modified: 2018-04-11 05:19:22 EDT
Description: The Class::Adapter class is intended as an abstract base class for creating any sort of class or object that follows the Adapter pattern. http://mmaslano.fedorapeople.org/perl-Class-Adapter/perl-Class-Adapter-1.05-1.fc10.src.rpm http://mmaslano.fedorapeople.org/perl-Class-Adapter/perl-Class-Adapter.spec
Please try to use the template when posting review requests.
+ GOOD: rpmlint is silent on both source and binary package. + GOOD: The package is named according to the Package Naming Guidelines . + GOOD: The spec file name matches the base package %{name}, in the format %{name}.spec. + GOOD: The package meets the Packaging Guidelines . + GOOD: The package is licensed with a Fedora approved license and meet the Licensing Guidelines . + GOOD: The License field in the package spec file matches the actual license. + GOOD: LICENSE file is in %doc. + GOOD: The spec file is written in American English. + GOOD: The spec file for the package is legible. + GOOD: The sources used to build the package matches the upstream source, as provided in the spec URL. 39b4b06a30b770ae5a7ee42dccdf143e Class-Adapter-1.05.tar.gz + GOOD: The package successfully compiles and build into binary rpms on at least one supported architecture. http://koji.fedoraproject.org/koji/taskinfo?taskID=915478 + GOOD: noarch, so it compiles everywhere. + GOOD: All build dependencies are listed in BuildRequires. + GOOD: The spec file MUST handle locales properly. No locale support. + GOOD: no libraries + GOOD: not relocatable + GOOD: A package owns all directories that it creates. Follows perl guidelines. + GOOD: A package must not contain any duplicate files in the %files listing. + GOOD: Permissions on files must be set properly. + GOOD: Each package have a %clean section. + GOOD: Each package consistently use macros. + GOOD: The package contains code, or permissable content. + GOOD: No large documentation files, so no a -doc subpackage. + GOOD: Files registered in %doc does not affect the runtime of the application. + GOOD: No header files. + GOOD: No static libraries. + GOOD: No pkgconfig(.pc) files. + GOOD: The package does not contain library files with a suffix. + GOOD: No devel packages. + GOOD: No .la libtool archives. + GOOD: Packages does not contain GUI applications. + GOOD: Packages does not own files or directories owned by other packages. + GOOD: Runs rm -rf $RPM_BUILD_ROOT in %install + GOOD: All filenames in rpm packages are valid UTF-8. + SHOULD: Includes license text.
Approved.
New Package CVS Request ======================= Package Name: perl-Class-Adapter Short Description: base for creating class follows the Adapter pattern Owners: mmaslano Branches: devel InitialCC: fedora-perl-devel-list@redhat.com
cvs done