Bug 469283 - ntfs-3g fdi file changes volume.fstype, breaks other hal rules
Summary: ntfs-3g fdi file changes volume.fstype, breaks other hal rules
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ntfs-3g
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-10-31 03:07 UTC by Bradley
Modified: 2008-11-07 02:57 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-07 02:51:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Bradley 2008-10-31 03:07:35 UTC
Description of problem:

/usr/share/hal/fdi/policy/10osvendor/20-ntfs-config-write-policy.fdi replaces volume.fstype with ntfs-3g where the type was previously ntfs

From the changelog it looks like this was an intentional change, although since my ntfs partitions were automounted before the change I'm not sure exactly what the fdi file is trying to do.

This change breaks existing hal rules; /usr/share/hal/fdi/policy/10osvendor/20-storage-methods.fdi has rules to ignore certain recovery partitions based on name and fstype.

Version-Release number of selected component (if applicable):

ntfs-3g-1.5012-3.fc9.x86_64
hal-0.5.11-2.fc9.x86_64

How reproducible:

Always

Steps to Reproduce:

By inspection, or:

1. Have a recovery partition that was previously ignored
2. Upgrade ntfs-3g to latest stable updates
  
Actual results:

Recovery partition is automatically mounted

Expected results:

As before, partition should be ignored

Additional info:

the way that hal finds and ignores recovery partitions has slightly changed upstream (https://bugs.freedesktop.org/show_bug.cgi?id=18027 and http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=fba24a693867984e832fd2eb8a182b715e66a289) but it still looks for ntfs as the file type

Comment 1 Tom "spot" Callaway 2008-10-31 13:44:50 UTC
Ugh. This hal nonsense gives me headaches.

So basically, we need the ntfs-3g provided .fdi to say:

<merge key="volume.fstype" type="string">ntfs</merge>

Right?

Comment 2 Bradley 2008-10-31 22:05:10 UTC
The match is on volume.fstype, so if you remove the merge line it should stay as ntfs (untested). But presumably its there for a reason, and I don't know enough about hal to know why.

Comment 3 Tom "spot" Callaway 2008-11-04 16:57:24 UTC
(In reply to comment #2)
> The match is on volume.fstype, so if you remove the merge line it should stay
> as ntfs (untested). But presumably its there for a reason, and I don't know
> enough about hal to know why.

Okay, since I don't have a recovery partition, can you manually edit /usr/share/hal/fdi/policy/10osvendor/20-ntfs-config-write-policy.fdi

Try (in this order):

1. Change the merge key volume.fstype string to be "ntfs" not "ntfs-3g".
2. Drop that merge key volume.fstype line altogether.

Please let me know if either change restores the behavior of ignoring recovery ntfs partitions.

Comment 4 Bradley 2008-11-04 20:26:53 UTC
Either of those work, and lshal shows volume.ignore is true (after restarting haldaemon)

Comment 5 Fedora Update System 2008-11-05 22:34:20 UTC
ntfs-3g-1.5012-4.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/ntfs-3g-1.5012-4.fc8

Comment 6 Fedora Update System 2008-11-05 22:34:22 UTC
ntfs-3g-1.5012-4.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/ntfs-3g-1.5012-4.fc9

Comment 7 Fedora Update System 2008-11-07 02:51:01 UTC
ntfs-3g-1.5012-4.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-11-07 02:57:05 UTC
ntfs-3g-1.5012-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.