Description of problem: These are more problems turned up by pychecker that require more complicated fixes. We plan to fix these through Snap3 and Snap4. iw/netconfig_dialog.py:176: No class attribute (_handleIPMissing) found iw/netconfig_dialog.py:193: No class attribute (_handleIPMissing) found iw/netconfig_dialog.py:201: No class attribute (_handleIPMissing) found network.py:346: No global (anaconda) found partedUtils.py:315: No global (device) found text.py:262: No global (MessageWindow) found text.py:413: Invalid arguments to (exceptionWindow), got 1, expected 2 textw/network_text.py:238: Object (ptpaddr) has no attribute (value) textw/network_text.py:239: Object (ptpaddr) has no attribute (value) text.py:475: No global (instkey) found So far, fixes available for text.py:262: No global (MessageWindow) found text.py:475: No global (instkey) found
(In reply to comment #0) > Description of problem: > > These are more problems turned up by pychecker that require more complicated > fixes. We plan to fix these through Snap3 and Snap4. > > iw/netconfig_dialog.py:176: No class attribute (_handleIPMissing) found > iw/netconfig_dialog.py:193: No class attribute (_handleIPMissing) found > iw/netconfig_dialog.py:201: No class attribute (_handleIPMissing) found To reproduce the problem caused by this: Do an ISO based install NOT a net install and then on the partitioning scheme select "advance storage" and then "add iscsi disk", then a network config dialog will be thrown up as iscsi needs network and that hasn't been brought up yet. Choose manual configuration here and then leave the ip-address empty. > text.py:262: No global (MessageWindow) found Do a textmode kickstart install with 'autopart --encrypted' in your ks.cfg (without "--passphrase="...") enter 2 different passphrases and press enter > textw/network_text.py:238: Object (ptpaddr) has no attribute (value) > textw/network_text.py:239: Object (ptpaddr) has no attribute (value) Reproducing this requires doing a text based s390 install with a cms conf file which does not specify the ip addresses for the ptp network interface (dcantrell sends his regards). > text.py:475: No global (instkey) found If you do a textmode install in the "enter installation key" dialog you see a bunch off grey (background color) boxes, where the product type for which to enter the key should be displayed
Created attachment 322585 [details] Patch fixing: text.py:475: No global (instkey) found
Created attachment 322586 [details] PAtch fixing: text.py:262: No global (MessageWindow) found
Created attachment 322587 [details] Patch fixing: textw/network_text.py:238: Object (ptpaddr) has no attribute (value)
Created attachment 322588 [details] Patch fixing: iw/netconfig_dialog.py:*: No class attribute (_handleIPMissing) found
Here us an updates.img which includes all these patches: http://people.atrpms.net/~hdegoede/updates.img
Created attachment 322673 [details] PATCH fixing: partedUtils.py:315: No global (device) found Note the last patch I attached for "partedUtils.py:315: No global (device) found" is not in the initial updates.img I provided and thus has not yet been tested. Here is an updated updates.img, with this patch included. http://people.atrpms.net/~hdegoede/updates-partedUtils.py.img
Created attachment 322715 [details] Patch fixing: network.py:346: No global (anaconda) found Note this patch is not in the initial updates.img I provided and thus has not yet been tested. Here is an updated updates.img, with this patch and the "partedUtils.py:315: No global (device) found" included. http://people.atrpms.net/~hdegoede/updates-network.py.img
Created attachment 322786 [details] Patch fixing: text.py:413: Invalid arguments to (exceptionWindow), got 1, expected 2 Ok, with this patch added to the list all issues pychecker found have been fixed, here is an updates.img including ALL fixes for this bug: http://people.atrpms.net/~hdegoede/updates-text.py.img
regression tests have completed successfully for all arches except ia64 (an independent infrastructure issue has kept those tests from completing successfully) ... based on the other arches results, we should be ok for the patches in the updates image in comment #13 ...
All attached patches commited except the 6th attachment, which fixes: network.py:346: No global (anaconda) found The fix for this needs to touch quite a few files and it turns out this is in a code path we don't use atm. So we're moving this patch to 5.4 to play it safe.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-0164.html