Bug 470177 (perl-Module-Util) - Review Request: perl-Module-Util - Module name tools and transformations
Summary: Review Request: perl-Module-Util - Module name tools and transformations
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Module-Util
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Module-Util
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-06 06:13 UTC by Chris Weyl
Modified: 2008-11-17 03:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-17 03:24:20 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-11-06 06:13:20 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Module-Util.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Module-Util-1.04-1.fc9.src.rpm

Description:
This module provides a few useful functions for manipulating module names.
Its main aim is to centralise some of the functions commonly used by
modules that manipulate other modules in some way, like converting module
names to relative paths.


Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=919203

Comment 1 Jason Tibbitts 2008-11-14 19:12:17 UTC
I note that 1.05 came out the day after you submitted this package.  It doesn't look like there's any significant differences between that and 1.04, so I'll go ahead and approve this package and if you like you can update when you check in.

* source files match upstream.  sha256sum:
   e3c556064dcf8fad412ddcf151bce5a23975f4e9ca966d02b55bd1bd1f1cbfc6  
   Module-Util-1.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Module::Util) = 1.04
   perl-Module-Util = 1.04-1.fc10
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
   perl(ExtUtils::MakeMaker)
   perl(File::Spec::Functions)
   perl(Getopt::Long)
   perl(List::Util)
   perl(Module::Util)
   perl(Pod::Usage)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   Files=2, Tests=45,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.05 cusr  0.01 
    csys =  0.08 CPU)
   Result: PASS

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Chris Weyl 2008-11-14 20:33:24 UTC
New Package CVS Request
=======================
Package Name: perl-Module-Util
Short Description: Module name tools and transformations
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2008-11-16 20:29:35 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.