Red Hat Bugzilla – Bug 471026
Review Request: chrony - An NTP client/server
Last modified: 2011-05-18 17:16:57 EDT
Spec URL: http://fedorapeople.org/~mlichvar/tmp/chrony.spec
SRPM URL: http://fedorapeople.org/~mlichvar/tmp/chrony-1.23-1.20081106gitbe42b4.fc10.src.rpm
A client/server for the Network Time Protocol, this program keeps your
computer's clock accurate. It was specially designed to support
systems with dial-up Internet connections, and also supports computers
in permanently connected environments.
formal review is here, see the notes below:
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
?? rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
?? correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- rpmlint complains a bit
chrony.src:52: W: configure-without-libdir-spec
hand-crafted configure script, can be ignored
chrony.x86_64: W: non-standard-uid /var/lib/chrony chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony chrony
chrony.x86_64: W: non-standard-uid /var/log/chrony chrony
chrony.x86_64: W: non-standard-gid /var/log/chrony chrony
chrony.x86_64: W: non-standard-uid /var/lib/chrony/rtc chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony/rtc chrony
chrony.x86_64: W: non-standard-uid /var/lib/chrony/drift chrony
chrony.x86_64: W: non-standard-gid /var/lib/chrony/drift chrony
chrony.x86_64: E: non-readable /etc/chrony.keys 0600
chrony.x86_64: W: log-files-without-logrotate /var/log/chrony
does chrony rotate the logs itself or ...?
- the texinfo postun scriptlet is called at wrong occasion (https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo)
chrony doesn't rotate the logs, but there is a small problem that it keeps the files open. It needs to be told to release them by cyclelogs command which requires authorization which requires a valid commandkey in chrony.keys file.
I'll try to fix both issues and post an update.
* Wed Nov 19 2008 Miroslav Lichvar <firstname.lastname@example.org> 1.23-2.20081106gitbe42b4
- fix info uninstall
- generate random command key in init script
- support cyclelogs, online, offline commands in init script
- add logrotate script
All issues are fixed, so this package is APPROVED.
One final note - the Guidelines recommend that you add a comment nearby the patches that tracks their upstream status: https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus
Thanks for the review.
New Package CVS Request
Package Name: chrony
Short Description: An NTP client/server
Branches: F-9 F-10
Package Change Request
Package Name: chrony
New Branches: el5 el6
Git done (by process-git-requests).