Bug 471275 - Review Request: mod_scgi - Python implementation of the SCGI protocol
Summary: Review Request: mod_scgi - Python implementation of the SCGI protocol
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-12 19:40 UTC by Marek Mahut
Modified: 2009-01-08 10:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-01-08 10:02:51 UTC
Type: ---
Embargoed:
lkundrak: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Marek Mahut 2008-11-12 19:40:35 UTC
Spec URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=929133
Description: The SCGI protocol is a replacement for the Common Gateway
Interface (CGI) protocol. It is a standard for applications
to interface with HTTP servers. It is similar to FastCGI
but is designed to be easier to implement.

Comment 2 Lubomir Rintel 2008-11-12 19:48:46 UTC
Thanks for the package. Taking this for review.

Comment 3 Lubomir Rintel 2008-12-05 15:12:24 UTC
Seems very well done.
Just two issues:

1.) Please depend on httpd ABI you built against:

This is best done by thepending on the Module Magic Number. This comes from mod_perl:

Requires:       httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing)

2.) RPMlint warnings:

mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/scgi_server.py 0644

mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/quixote_handler.py 0644

What about these? Are they run by the module? If yes, move them to libexec. No? Move them to bin. Change the mode appropriately.

mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/test_passfd.py 0644

You should probably not bundle this. If you mind completely removing this, mark it as %doc-umentation.

Comment 5 Lubomir Rintel 2008-12-20 15:47:51 UTC
(In reply to comment #4)
> All should be fixed.

Seems fine now. I have a strong feeling you mistyped the SRPM URL though :)

> SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec

Doesn't matter much since all changes were in SPEC file only.

APPROVED

Comment 6 Marek Mahut 2008-12-21 11:32:16 UTC
New Package CVS Request
=======================
Package Name: mod_scgi
Short Description: Python implementation of the SCGI protocol
Owners: mmahut
Branches: EL-5 F-9 F-10

Comment 7 Kevin Fenzi 2008-12-23 02:41:08 UTC
cvs done.

Comment 8 Lubomir Rintel 2009-01-08 00:46:24 UTC
Marek please import and build this

Comment 9 Marek Mahut 2009-01-08 10:02:51 UTC
Sorry for the delay, done.

Thank you for the review.


Note You need to log in before you can comment on or make changes to this bug.