Red Hat Bugzilla – Bug 471275
Review Request: mod_scgi - Python implementation of the SCGI protocol
Last modified: 2009-01-08 05:02:51 EST
Spec URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=929133 Description: The SCGI protocol is a replacement for the Common Gateway Interface (CGI) protocol. It is a standard for applications to interface with HTTP servers. It is similar to FastCGI but is designed to be easier to implement.
SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi-1.13-1.fc8.src.rpm
Thanks for the package. Taking this for review.
Seems very well done. Just two issues: 1.) Please depend on httpd ABI you built against: This is best done by thepending on the Module Magic Number. This comes from mod_perl: Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing) 2.) RPMlint warnings: mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/scgi_server.py 0644 mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/quixote_handler.py 0644 What about these? Are they run by the module? If yes, move them to libexec. No? Move them to bin. Change the mode appropriately. mod_scgi.i386: E: non-executable-script /usr/lib/python2.4/site-packages/scgi/test_passfd.py 0644 You should probably not bundle this. If you mind completely removing this, mark it as %doc-umentation.
All should be fixed. Spec URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec
(In reply to comment #4) > All should be fixed. Seems fine now. I have a strong feeling you mistyped the SRPM URL though :) > SRPM URL: http://mmahut.fedorapeople.org/reviews/mod_scgi/mod_scgi.spec Doesn't matter much since all changes were in SPEC file only. APPROVED
New Package CVS Request ======================= Package Name: mod_scgi Short Description: Python implementation of the SCGI protocol Owners: mmahut Branches: EL-5 F-9 F-10
cvs done.
Marek please import and build this
Sorry for the delay, done. Thank you for the review.