Bug 471496 - revert closed reason patch [NEEDINFO]
Summary: revert closed reason patch
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libnotify
Version: 10
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Zeuthen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-13 23:45 UTC by Peter Robinson
Modified: 2013-03-06 03:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-06 07:42:41 UTC
Type: ---
cwickert: needinfo? (davidz)


Attachments (Terms of Use)

Description Peter Robinson 2008-11-13 23:45:52 UTC
The libnotify-closed-reason.patch breaks the libnotify api and has since been reverted upstream according to revision 3014, the change says "Prevent a backwards-compatibility breakage introduced where the "reason" code was added to the "closed" signal."

It was the cause of the ekiga crash in bug # 469132

Comment 1 Bug Zapper 2008-11-26 05:21:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle.
Changing version to '10'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Peter Robinson 2009-01-06 07:42:41 UTC
This has now been dropped in rawhide and I've dropped the patch that was added to ekiga in Fedora 10 for the rawhide build so it didn't crash due to this patch. No idea what impact this will have on other packages.

Comment 3 Christoph Wickert 2009-02-15 11:27:39 UTC
Any change we also get this into F10? It really sucks having to patch all apps that use libnotify for every new release they make.

The change was reverted upstream in http://trac.galago-project.org/changeset/3014 on September 26 2008 which was before F10 beta freeze, so I really think it should have been in F10 anyway.


Note You need to log in before you can comment on or make changes to this bug.