Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss-1.1-1.fc9.src.rpm Description: A simple, flexible, extensible, and liberal RSS and Atom reader for Ruby
I will review this. Instead I would appreciate it if you would review my review request for rubygem-hpricot (bug 477526)
For 1.1-1: * License - License tag must be "LGPLv2+" * Documents - Please check if Rakefile is really needed. - README, LICENSE should be marked as %doc. * %geminstdir --------------------------------------------------------- %files %{gemdir}/gems/%{gemname}-%{version}/ --------------------------------------------------------- - can be replaced by %{geminstdir}/ because you defined this macro.
ping?
I will try to get to this tonight.
License -- Fixed Documents -- Not sure on this one. Most gems have README in /usr/lib/ruby/.... A few examples. /usr/lib/ruby/gems/1.8/gems/actionmailer-2.1.1/README /usr/lib/ruby/gems/1.8/gems/actionpack-2.1.1/README /usr/lib/ruby/gems/1.8/gems/activerecord-2.1.1/README /usr/lib/ruby/gems/1.8/gems/activeresource-2.1.1/README /usr/lib/ruby/gems/1.8/gems/activesupport-2.1.1/README /usr/lib/ruby/gems/1.8/gems/cgi_multipart_eof_fix-2.3/README /usr/lib/ruby/gems/1.8/gems/daemons-1.0.10/README /usr/lib/ruby/gems/1.8/gems/daemons-1.0.7/README /usr/lib/ruby/gems/1.8/gems/eventmachine-0.12.2/README /usr/lib/ruby/gems/1.8/gems/fcgi-0.8.7/README /usr/lib/ruby/gems/1.8/gems/fcgi-0.8.7/README.signals I am not opposed to it either way, but if it is installing as a gem, I don't know that I can unpack and relocate the README file easily. Any suggestions? Fixed macro. http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss-1.1-2.fc10.src.rpm http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss.spec
Well, I am just saying that README file should be marked as %doc, not suggesting that README file should be relocated.
OK, README file now marked as Doc. http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss-1.1-3.fc10.src.rpm http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss.spec
For 1.1-3: * License - License tag should be "LGPLv2+", not with "or Ruby". * duplicate files - Now build.log shows: ------------------------------------------------------- 49 Processing files: rubygem-simple-rss-1.1-3.fc11 50 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/simple-rss-1.1/README ------------------------------------------------------- One of the way to suppress this warning is: ------------------------------------------------------- %files %defattr(-,root,root,-) %dir %{geminstdir}/ %doc %{geminstdir}/[A-Z]* %{geminstdir}/*/ ------------------------------------------------------- ! By the way, please use macros consistently. You use both %{gemdir}/gems/%{gemname}-%{version}/ and %{geminstdir} at %files, however these are the same.
Thanks for the updates. I have updated the packages. I am working on your other review too! http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss-1.1-4.fc10.src.rpm http://stahnma.fedorapeople.org/reviews/rubygem-simple-rss.spec
Okay. --------------------------------------------------------------- This package (rubygem-simple-rss) is APPROVED by mtasaka ---------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-simple-rss Short Description: A simple, flexible, extensible, and liberal RSS and Atom reader for Ruby Owners: stahnma kanarip Branches: F-9 F-10 InitialCC:
cvs done.
New Package CVS Request ======================= Package Name: rubygem-simple-rss Short Description: A simple, flexible, extensible, and liberal RSS and Atom reader for Ruby Owners: stahnma kanarip Branches: EL-5 InitialCC:
- Please rebuild also on F-9 - And for F-10 F-9, please submit requests to push the rebuilt packages into repositories on bodhi: https://admin.fedoraproject.org/updates/
rubygem-simple-rss-1.1-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-simple-rss-1.1-4.fc10
rubygem-simple-rss-1.1-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-simple-rss'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2300
Now closing.
rubygem-simple-rss-1.1-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.