Bug 471576 - libata: Avoid overflow in ata_tf_read_block() when tf->hba_lbal > 127
Summary: libata: Avoid overflow in ata_tf_read_block() when tf->hba_lbal > 127
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: David Milburn
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-14 12:31 UTC by David Milburn
Modified: 2009-01-20 20:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 20:10:26 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Upstream patch to correct problem (576 bytes, patch)
2008-11-14 12:31 UTC, David Milburn 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:0225 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.3 kernel security and bug fix update 2009-01-20 16:06:24 UTC

Description David Milburn 2008-11-14 12:31:30 UTC 
Created attachment 323567 [details]
Upstream patch to correct problem

Possible overflow in ata_tf_read_block

commit 44901a96847b9967c057832b185e2f34ee6a14e5
Author: Roland Dreier <rdreier>
Date:   Tue Nov 4 10:34:48 2008 -0800

    libata: Avoid overflow in ata_tf_read_block() when tf->hba_lbal > 127
    
    Phillip O'Donnell <phillip.odonnell> pointed out that the same
    sign extension bug that was fixed in commit ba14a9c2 ("libata: Avoid
    overflow in ata_tf_to_lba48() when tf->hba_lbal > 127") also appears to
    exist in ata_tf_read_block().  Fix this by adding a cast to u64.
    
    Signed-off-by: Roland Dreier <rolandd>
    Signed-off-by: Jeff Garzik <jgarzik>
Comment 3 David Milburn 2008-11-17 17:46:53 UTC 
This was a follow-up from BZ 469715.
Comment 5 Don Zickus 2008-11-18 21:21:34 UTC 
in kernel-2.6.18-124.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5
Comment 10 errata-xmlrpc 2009-01-20 20:10:26 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html
Note You need to log in before you can comment on or make changes to this bug.