Hide Forgot
Spec URL: http://fedorapeople.org/~cweyl/review/perl-asa.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-asa-0.02-1.fc9.src.rpm Description: Perl 5 doesn't natively support Java-style interfaces, and it doesn't support Perl 6 style roles either. You can get both of these things in half a dozen different ways via various CPAN modules, but they usually require that you buy into "their way" of implementing your code. This package overrides the isa() method, allowing your class to claim it's a class it's not (that is, isn't in @ISA). Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=939375
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=939617 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b2b0358f0c8548dacdbdaeaa7c9fe5f7 asa-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=21, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.18 cusr 0.03 csys = 0.24 CPU) + Package perl-asa-0.02-1.fc11 Provides: perl(asa) = 0.02 Requires: perl >= 0:5.005 perl(Carp) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-asa Short Description: Lets your class/object say it works like something else Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig
cvs done.
Package Change Request ====================== Package Name: perl-asa New Branches: el6 Owners: jpo InitialCC: perl-sig [perl-Dancer requirement chain - see bug 729504]
Git done (by process-git-requests).