Bug 472179 (perl-Test-Block) - Review Request: perl-Test-Block - Specify fine granularity test plans
Summary: Review Request: perl-Test-Block - Specify fine granularity test plans
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Test-Block
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Test-Block
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-19 07:51 UTC by Chris Weyl
Modified: 2008-11-23 07:56 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-23 07:56:55 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-11-19 07:51:17 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Test-Block.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Test-Block-0.11-1.fc9.src.rpm

Description:
This module allows you to specify the number of expected tests at a finer
level of granularity than an entire test script. It is built with
Test::Builder and plays happily with Test::More and friends.


Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=939474

Comment 1 Chris Weyl 2008-11-19 07:51:54 UTC
This package is a dependency of App::Asciio.

Comment 2 Parag AN(पराग) 2008-11-19 09:28:34 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=939616
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
386a722947f2c77f6157d1dea0338e35  Test-Block-0.11.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=26,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.19 cusr  0.02
csys =  0.24 CPU)

+ Package Package perl-Test-Block-0.11-1.fc11
  Provides: perl(Test::Block) = 0.11 perl(Test::Block::Plan)
  Requires: perl(Carp) perl(Scalar::Util) perl(Test::Builder) perl(Tie::Scalar)
perl(base) perl(overload) perl(strict) perl(warnings)

APPROVED.

Comment 3 Chris Weyl 2008-11-19 16:31:03 UTC
New Package CVS Request
=======================
Package Name: perl-Test-Block
Short Description: Specify fine granularity test plans
Owners: cweyl
Branches: F-8 F-9 F-10 devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-11-23 04:26:36 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.