Bug 472662 - Review Request: beanstalkd - fast, distributed, in-memory workqueue service
Summary: Review Request: beanstalkd - fast, distributed, in-memory workqueue service
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-11-23 06:54 UTC by Jeremy Hinegardner
Modified: 2008-12-31 05:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-12-31 05:58:17 UTC
Type: ---
Embargoed:
kevin: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jeremy Hinegardner 2008-11-23 06:54:38 UTC
Spec URL: http://jjh.fedorapeople.org/beanstalkd/beanstalkd.spec
SRPM URL: http://jjh.fedorapeople.org/beanstalkd/beanstalkd-1.1-1.fc10.src.rpm
Description: beanstalkd is a fast, distributed, in-memory workqueue service. Its
interface is generic, but was originally designed for reducing the
latency of page views in high-volume web applications by running most
time-consuming tasks asynchronously.

Comment 1 Kevin Fenzi 2008-12-04 04:09:06 UTC
I'll go ahead and review this... look for a full review in a bit.

Comment 2 Kevin Fenzi 2008-12-04 04:20:45 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
36be022bb59545df51b537f0e423d2d6  beanstalkd-1.1.tar.gz
36be022bb59545df51b537f0e423d2d6  beanstalkd-1.1.tar.gz.orig

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

None.

I don't see any issues here, this package is APPROVED.

Comment 3 Jeremy Hinegardner 2008-12-04 06:27:55 UTC
New Package CVS Request
=======================
Package Name: beanstalkd
Short Description: A fast, distributed, in-memory workqueue service
Owners: jjh
Branches: F-9 F-10
InitialCC:

Comment 4 Kevin Fenzi 2008-12-05 05:11:45 UTC
cvs done. 

Do consider supporting EPEL if this package builds/works on EL hosts.

Comment 5 Jeremy Hinegardner 2008-12-05 17:52:06 UTC
Thanks, that is the plan.

Comment 6 Jeremy Hinegardner 2008-12-31 05:27:01 UTC
Package Change Request
======================
Package Name: beanstalkd
New Branches: EL-5
Owners: jjh

Comment 7 Kevin Fenzi 2008-12-31 05:46:52 UTC
cvs done.

Comment 8 Jeremy Hinegardner 2008-12-31 05:58:17 UTC
builds and updates submitted


Note You need to log in before you can comment on or make changes to this bug.