Hide Forgot
Spec URL: http://oget.fedorapeople.org/review/pytagger.spec SRPM URL: http://oget.fedorapeople.org/review/pytagger-0.5-1.fc9.src.rpm Description: pytagger is a ID3 tag reader and writer implemented purely in Python. It supports all the current ID3 tag implementations including ID3v1, ID3v1.1, ID3v2.2, ID3v2.3 and ID3v2.4. ------------------------------------------------------------------------ rpmlint is silent. I didn't run the test scripts because they need some extra audio files which are not provided by upstream.
Note, I am unsponsored so I cannot approve this MUSTS: *rpmlint -- passes cleanly in mock on rpm srpm and spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. *Package name correct *Spec name correct *Licensed fedora safe and correct *Licence files is not in its own file so %doc is ok without it *spec in english *spec is readable *md5sum is same as source file 0af47e825f510204d839cb190743ad40 *builds in mock *builds in mock so buildrequires are good *locales N/A *library files N/A *not designed to be relocatable *owns created dirs *permissions set *no large docs *%docs not runtime *no devel needed *no static libs *no .pc files *no .la files *not gui app *does not take ownership of other packages files *buildroot cleaned at start of %install *all file names valid UTF-8 SHOULDS: I did not see the licence as a separate file has upstream been notified? Any spec descriptions available? Builds fine in mock. Builds for all arch (noarch) I have not done a functionality test. No scriptlets. No subpackages. This package looks good to me, may want to look into the two questions I put in the SHOULDS section.
Hi. Thanks for your time. I hope you get sponsored soon. - Actually, the license file is there. It is the COPYING file. The name "COPYING" is a common name for license files. - Spec descriptions... I think I strictly followed the python guidelines: http://fedoraproject.org/wiki/Packaging/Python Do you think there is something that is not clear?
(In reply to comment #2) > Hi. Thanks for your time. I hope you get sponsored soon. > > - Actually, the license file is there. It is the COPYING file. The name > "COPYING" is a common name for license files. I remember reading that file, not sure why I said that. > > - Spec descriptions... I think I strictly followed the python guidelines: > http://fedoraproject.org/wiki/Packaging/Python > Do you think there is something that is not clear? I was referring to this part of the review guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. But as it says if available, so by no means is that a blocking issue.
(In reply to comment #3) > I was referring to this part of the review guidelines > > http://fedoraproject.org/wiki/Packaging/ReviewGuidelines > - SHOULD: The description and summary sections in the package spec file should > contain translations for supported Non-English languages, if available. > > But as it says if available, so by no means is that a blocking issue. Yes, you're right. There's been an ongoing discussion about this in the mailing list. We need more translators. While the guidelines suggest it, unfortunately, it never became a common exercise among packagers.
Now that I am sponsored, I will go through this again for you.
I took another look at this, and it still looks fine, so I am going to: APPROVE It. Go ahead and place your CVS Request.
I had marked as assigned but forgot to add my self as the assignee.
Thank you Brennan. New Package CVS Request ======================= Package Name: pytagger Short Description: ID3 Tag Reader and Writer Library for Python Owners: oget Branches: F-9 F-10 devel InitialCC:
cvs done.
pytagger-0.5-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/pytagger-0.5-1.fc9
pytagger-0.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/pytagger-0.5-1.fc10
pytagger-0.5-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pytagger'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11302
pytagger-0.5-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update pytagger'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11317
pytagger-0.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
pytagger-0.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.